Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(247)

Issue 11465045: daemon: fix PropertiesChanged signal emission (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Daiki Ueno
Modified:
12 years, 6 months ago
Reviewers:
shawn.p.huang, fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

daemon: fix PropertiesChanged signal emission This fixes a few problems of PropertiesChanged signal emission. First, it should be sent only when the properties have changed. Second, invalidated_properties should be set when the properties have been reset, not on error. Finally, the sender should be "org.freedesktop.IBus" rather than "org.freedesktop.DBus". BUG= R=takao.fujiwara1@gmail.com Committed: 583bfe6

Patch Set 1 #

Patch Set 2 : remove unused local variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -59 lines) Patch
M bus/ibusimpl.c View 1 6 chunks +47 lines, -59 lines 0 comments Download

Messages

Total messages: 5
Daiki Ueno
For https://codereview.appspot.com/11422043/, I looked at the set/get properties code in ibusimpl.c, and noticed that the ...
12 years, 6 months ago (2013-07-24 04:10:32 UTC) #1
Peng
+Fujiwara-san for review
12 years, 6 months ago (2013-07-24 14:24:39 UTC) #2
Peng
On 2013/07/24 14:24:39, Peng wrote: > +Fujiwara-san for review Look good to me. But please ...
12 years, 6 months ago (2013-07-24 14:27:32 UTC) #3
fujiwara
LGTM. Looks good. On 2013/07/24 04:10:32, Daiki Ueno wrote: > - unused "connection" parameter for ...
12 years, 6 months ago (2013-07-25 05:20:04 UTC) #4
Daiki Ueno
12 years, 6 months ago (2013-07-25 09:12:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r583bfe6 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b