Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1713)

Issue 114640044: code review 114640044: go/build: perform simple variable substitution in #cgo lines

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 3 months ago by cookieo9
Modified:
4 years, 11 months ago
Reviewers:
aram, slimsag
CC:
golang-codereviews, slimsag, aram
Visibility:
Public.

Description

go/build: perform simple variable substitution in #cgo lines Expands $SRCDIR and ${SRCDIR}, into the path to the source directory of the package being built. Fixes Issue 7891. Fixes Issue 5428.

Patch Set 1 #

Patch Set 2 : diff -r b673250d7b72 http://code.google.com/p/go #

Patch Set 3 : diff -r bfe2cc97b9e1 http://code.google.com/p/go #

Patch Set 4 : diff -r 71a2dfec0640 http://code.google.com/p/go #

Patch Set 5 : diff -r dff49040426d http://code.google.com/p/go #

Patch Set 6 : diff -r 19201bb04c4fc975273e0d9f8d68bf844d1163cd http://code.google.com/p/go #

Patch Set 7 : diff -r e54b1af55910c77e4a215112193472f0276b3c8d http://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M src/go/build/build.go View 1 2 3 4 5 6 2 chunks +9 lines, -1 line 0 comments Download
M src/go/build/build_test.go View 1 2 3 4 5 6 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 12
cookieo9
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to http://code.google.com/p/go
5 years, 3 months ago (2014-08-01 14:31:26 UTC) #1
slimsag
On 2014/08/01 14:31:26, cookieo9 wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...
5 years, 3 months ago (2014-08-01 17:35:32 UTC) #2
cookieo9
On 2014/08/01 17:35:32, slimsag wrote: > On 2014/08/01 14:31:26, cookieo9 wrote: > > Hello mailto:golang-codereviews@googlegroups.com, ...
5 years, 3 months ago (2014-08-01 21:35:12 UTC) #3
slimsag
On 2014/08/01 21:35:12, cookieo9 wrote: > On 2014/08/01 17:35:32, slimsag wrote: > > On 2014/08/01 ...
5 years, 3 months ago (2014-08-01 23:44:34 UTC) #4
cookieo9
On 2014/08/01 23:44:34, slimsag wrote: > On 2014/08/01 21:35:12, cookieo9 wrote: > > On 2014/08/01 ...
5 years, 3 months ago (2014-08-02 01:43:35 UTC) #5
cookieo9
A more complex, but accurate expandVars function (if needed): http://play.golang.org/p/W0TKkOAHsF
5 years, 3 months ago (2014-08-02 07:53:40 UTC) #6
slimsag
I think I understand your points, but I still argue that #cgo lines do not ...
5 years, 3 months ago (2014-08-02 16:54:40 UTC) #7
cookieo9
On 2014/08/02 16:54:40, slimsag wrote: > I think I understand your points, but I still ...
5 years, 3 months ago (2014-08-03 05:10:25 UTC) #8
cookieo9
I have added table driven tests for the expandVars function. The tests check as many ...
5 years, 3 months ago (2014-08-03 05:53:54 UTC) #9
aram
NOT LGTM Please open a thread on golang-dev about this. It is very unclear why ...
5 years, 3 months ago (2014-08-04 12:15:38 UTC) #10
slimsag
On 2014/08/04 12:15:38, aram wrote: > NOT LGTM > > Please open a thread on ...
5 years, 3 months ago (2014-08-04 17:08:59 UTC) #11
gobot
4 years, 11 months ago (2014-12-19 05:10:54 UTC) #12
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/114640044 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b