Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 11458044: allow numeric font-weight in client-side css sanitizer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by felix8a
Modified:
12 years, 7 months ago
Reviewers:
MikeSamuel
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

font-weight is special because the allowed value list includes things that look like numbers. The client-side css parser applies numeric value checks before literal value checks, so font-weight:200 is always elided. This fixes that by moving the literal value check before the numeric value check. This fixes https://code.google.com/p/google-caja/issues/detail?id=1771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M src/com/google/caja/plugin/sanitizecss.js View 5 chunks +21 lines, -10 lines 0 comments Download
M tests/com/google/caja/plugin/css-stylesheet-tests.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
felix8a
12 years, 7 months ago (2013-07-17 20:28:52 UTC) #1
MikeSamuel
LGTM
12 years, 7 months ago (2013-07-17 22:03:47 UTC) #2
felix8a
12 years, 7 months ago (2013-07-17 22:11:24 UTC) #3
@r5497
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b