code review 11457044: misc/emacs: Make godef-jump behave more like find-tag b...

misc/emacs/go-mode.el

 ;;; go-mode.el --- Major mode for the Go programming language
 
 ;; Copyright 2013 The Go Authors. All rights reserved.
 ;; Use of this source code is governed by a BSD-style
 ;; license that can be found in the LICENSE file.
 
 (require 'cl)
 (require 'etags)

[adonovan, 2013/07/24 14:52:21]

Also: (require 'ring)

It's good practice to declare all your direct dependencies rather than rely on
the transitivity of "require", as this makes your code more robust against later
refactorings.

 (require 'ffap)
+(require 'ring)
 (require 'url)
 
 ;; XEmacs compatibility guidelines
 ;; - Minimum required version of XEmacs: 21.5.32
 ;;   - Feature that cannot be backported: POSIX character classes in
 ;;     regular expressions
 ;;   - Functions that could be backported but won't because 21.5.32
 ;;     covers them: plenty.
 ;;   - Features that are still partly broken:
 ;;     - godef will not work correctly if multibyte characters are
@@ skipping 908 matching lines @@
           (push-mark)
           (ring-insert find-tag-marker-ring (point-marker))
           (godef--find-file-line-column file other-window))))
     (file-error (message "Could not run godef binary"))))
 
 (defun godef-jump-other-window (point)
   (interactive "d")
   (godef-jump point t))
 
 (provide 'go-mode)