Rename GetHeapType to GetHeapFeatures, and add optional IsAllocated function.

Rename GetHeapType to GetHeapFeatures, and add optional IsAllocated function.

This adds support for an optionally implemented ability to query a heap if it has made the given allocation. The HeapManager will require this when recovering from a corrupted BlockTrailer.

BUG=
R=sebmarchand@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=2213

[chrisha, 2014-07-30 21:23:33]

PTAL?

(This is the same way in which I plan to eventually add heap walking support...)

[Sébastien Marchand, 2014-07-30 22:40:14]

lgtm.

https://codereview.appspot.com/114570043/diff/1/syzygy/agent/asan/heap.h
File syzygy/agent/asan/heap.h (right):

https://codereview.appspot.com/114570043/diff/1/syzygy/agent/asan/heap.h#newc...
syzygy/agent/asan/heap.h:79: // @note This will always return false unless the
heap has the
Should this function be pure virtual in this case ? Why not providing a default
implementation returning false ?

If you don't provide a default implementation maybe s/will/should/ so the reader
will know that he have to take care of this ?

https://codereview.appspot.com/114570043/diff/1/syzygy/agent/asan/heap.h#newc...
syzygy/agent/asan/heap.h:80: //     kHeapConfirmsOwnership feature.
s/kHeapConfirmsOwnership/kHeapSupportsIsAllocated/

https://codereview.appspot.com/114570043/diff/1/syzygy/agent/asan/heaps/simpl...
File syzygy/agent/asan/heaps/simple_block_heap_unittest.cc (right):

https://codereview.appspot.com/114570043/diff/1/syzygy/agent/asan/heaps/simpl...
syzygy/agent/asan/heaps/simple_block_heap_unittest.cc:76: void* a =
h.Allocate(100);
Add a small comment about the fact that this heap doesn't support the
IsAllocated function ?

[chrisha, 2014-07-31 14:04:16]

Thanks, committing.

https://codereview.appspot.com/114570043/diff/1/syzygy/agent/asan/heap.h
File syzygy/agent/asan/heap.h (right):

https://codereview.appspot.com/114570043/diff/1/syzygy/agent/asan/heap.h#newc...
syzygy/agent/asan/heap.h:79: // @note This will always return false unless the
heap has the
On 2014/07/30 22:40:14, Sébastien Marchand wrote:
> Should this function be pure virtual in this case ? Why not providing a
default
> implementation returning false ?
> 
> If you don't provide a default implementation maybe s/will/should/ so the
reader
> will know that he have to take care of this ?

This is an interface, so should not provide any implementations. If we want to
provide default implementations we generally do so with a template 'impl',
similar to the NamedBlockTransformImpl, etc, for transforms. However, using
implementing a single 'return false' function is about as easy, so I elected not
to create such an impl class.

The fact that this is pure virtual implies the derived class is repsonsible for
the implementation.

https://codereview.appspot.com/114570043/diff/1/syzygy/agent/asan/heap.h#newc...
syzygy/agent/asan/heap.h:80: //     kHeapConfirmsOwnership feature.
On 2014/07/30 22:40:14, Sébastien Marchand wrote:
> s/kHeapConfirmsOwnership/kHeapSupportsIsAllocated/

Done.

https://codereview.appspot.com/114570043/diff/1/syzygy/agent/asan/heaps/simpl...
File syzygy/agent/asan/heaps/simple_block_heap_unittest.cc (right):

https://codereview.appspot.com/114570043/diff/1/syzygy/agent/asan/heaps/simpl...
syzygy/agent/asan/heaps/simple_block_heap_unittest.cc:76: void* a =
h.Allocate(100);
On 2014/07/30 22:40:14, Sébastien Marchand wrote:
> Add a small comment about the fact that this heap doesn't support the
> IsAllocated function ?

Done.

[chrisha, 2014-07-31 14:24:01]

Committed patchset #2 manually as r2213.