Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 11422043: Notify engines of the content-type of input context (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by Daiki Ueno
Modified:
11 years, 2 months ago
Reviewers:
shawn.p.huang, fujiwara, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Notify engines of the content-type of input context Add a new D-Bus method SetContentType to InputContext and Engine, to notify engines of the content-type (primary purpose and hints) of input context. This is useful to implement intelligent features in engines, such as automatic input-mode switch and text prediction. The "purpose" and "hints" arguments are compatible with GtkInputPurpose and GtkInputHints: https://developer.gnome.org/gtk3/unstable/GtkEntry.html#GtkInputPurpose https://developer.gnome.org/gtk3/unstable/GtkEntry.html#GtkInputHints and the API is similar to the content_type event in the Wayland Input Method Framework: http://cgit.freedesktop.org/wayland/weston/tree/protocol/input-method.xml#n202 BUG= Committed: 3b3a7ce

Patch Set 1 #

Patch Set 2 : monitor property notification #

Total comments: 2

Patch Set 3 : use DBus properties #

Patch Set 4 : fix GVariant ref leak #

Patch Set 5 : simplify set-property dispatch in bus/inputcontext.c #

Patch Set 6 : don't touch ibusservice.c #

Total comments: 12

Patch Set 7 : wrap too long lines and add example to docs #

Total comments: 12

Patch Set 8 : wrap too long comment lines #

Patch Set 9 : forgot to emit "set-content-type" signal in IBusEngine #

Unified diffs Side-by-side diffs Delta from patch set Stats (+727 lines, -181 lines) Patch
M bus/engineproxy.h View 1 2 3 4 5 6 7 3 chunks +148 lines, -73 lines 0 comments Download
M bus/engineproxy.c View 1 2 3 4 5 3 chunks +36 lines, -4 lines 0 comments Download
M bus/inputcontext.c View 1 2 3 4 5 6 7 15 chunks +190 lines, -59 lines 0 comments Download
M client/gtk2/ibusimcontext.c View 1 2 3 4 5 8 chunks +40 lines, -14 lines 0 comments Download
M src/ibusengine.h View 1 2 3 4 5 6 4 chunks +29 lines, -8 lines 0 comments Download
M src/ibusengine.c View 1 2 3 4 5 6 7 8 12 chunks +154 lines, -13 lines 0 comments Download
M src/ibusinputcontext.h View 1 2 3 4 5 6 2 chunks +22 lines, -2 lines 0 comments Download
M src/ibusinputcontext.c View 1 2 3 4 5 6 4 chunks +38 lines, -6 lines 0 comments Download
M src/ibustypes.h View 1 2 3 4 5 2 chunks +70 lines, -2 lines 0 comments Download

Messages

Total messages: 9
Daiki Ueno
Related to https://codereview.appspot.com/7064059/#msg2
11 years, 4 months ago (2013-07-17 06:15:42 UTC) #1
Peng
https://codereview.appspot.com/11422043/diff/4001/src/ibusinputcontext.h File src/ibusinputcontext.h (right): https://codereview.appspot.com/11422043/diff/4001/src/ibusinputcontext.h#newcode465 src/ibusinputcontext.h:465: (IBusInputContext *context, I suggest using dbus property for it. ...
11 years, 4 months ago (2013-07-17 14:50:41 UTC) #2
Daiki Ueno
https://codereview.appspot.com/11422043/diff/4001/src/ibusinputcontext.h File src/ibusinputcontext.h (right): https://codereview.appspot.com/11422043/diff/4001/src/ibusinputcontext.h#newcode465 src/ibusinputcontext.h:465: (IBusInputContext *context, On 2013/07/17 14:50:41, Peng wrote: > I ...
11 years, 3 months ago (2013-07-19 02:52:45 UTC) #3
Daiki Ueno
Ping. I've uploaded a new CL whose coding style now matches ibusimpl.c. Could you review ...
11 years, 3 months ago (2013-08-12 09:23:20 UTC) #4
Peng
https://codereview.appspot.com/11422043/diff/18001/bus/engineproxy.h File bus/engineproxy.h (right): https://codereview.appspot.com/11422043/diff/18001/bus/engineproxy.h#newcode259 bus/engineproxy.h:259: void bus_engine_proxy_set_content_type More than 80 chars. Could please fix ...
11 years, 3 months ago (2013-08-12 16:26:13 UTC) #5
Daiki Ueno
Thanks, fixed style and docs. https://codereview.appspot.com/11422043/diff/18001/bus/engineproxy.h File bus/engineproxy.h (right): https://codereview.appspot.com/11422043/diff/18001/bus/engineproxy.h#newcode259 bus/engineproxy.h:259: void bus_engine_proxy_set_content_type On 2013/08/12 ...
11 years, 3 months ago (2013-08-13 13:17:36 UTC) #6
Peng
lgtm with several comments https://codereview.appspot.com/11422043/diff/29001/bus/engineproxy.h File bus/engineproxy.h (right): https://codereview.appspot.com/11422043/diff/29001/bus/engineproxy.h#newcode72 bus/engineproxy.h:72: * Get the result of ...
11 years, 3 months ago (2013-08-13 14:59:42 UTC) #7
Daiki Ueno
Fixed too long comment lines and wrong gtk-doc markups. https://codereview.appspot.com/11422043/diff/29001/bus/engineproxy.h File bus/engineproxy.h (right): https://codereview.appspot.com/11422043/diff/29001/bus/engineproxy.h#newcode72 bus/engineproxy.h:72: ...
11 years, 3 months ago (2013-08-14 09:26:21 UTC) #8
fujiwara
11 years, 2 months ago (2013-08-30 02:35:01 UTC) #9
Message was sent while issue was closed.
I modified _set_content_type in CL 13255047.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b