fix event test for firefox 23 (beta) and 24 (aurora)

keyboard events are supposed to have an event.key property, which is
the new hotness obsoleting event.keyCode. firefox doesn't implement
event.key yet, and different versions of firefox fail to implement
event.key in different ways.

firefox 22 doesn't have an event.key property.
firefox 23 and 24 has an event.key property and it seems to be always ''.
the '' value is causing a spurious browser test failure.

this mutes that failure.

this fixes https://code.google.com/p/google-caja/issues/detail?id=1805

[kpreid2, 2013-07-17 16:44:02]

https://codereview.appspot.com/11416044/diff/1/tests/com/google/caja/plugin/e...
File tests/com/google/caja/plugin/es53-test-domado-events-guest.html (right):

https://codereview.appspot.com/11416044/diff/1/tests/com/google/caja/plugin/e...
tests/com/google/caja/plugin/es53-test-domado-events-guest.html:940: if
(directAccess.feralFeatureTest(event, 'key') && event.key != '') {
Use directAccess.getFeralProperty(event, 'key') instead so that the test doesn't
pass if tame event.key is always ''.

!== not !=

[felix8a, 2013-07-17 16:51:48]

keyboard events are supposed to have an event.key property, which is
the new hotness obsoleting event.keyCode. firefox doesn't implement
event.key yet, and different versions of firefox fail to implement
event.key in different ways.

firefox 22 doesn't have an event.key property.
firefox 23 and 24 has an event.key property and it seems to be always ''.
the '' value is causing a spurious browser test failure.

this mutes that failure.

this fixes https://code.google.com/p/google-caja/issues/detail?id=1805

[felix8a, 2013-07-17 16:52:12]

https://codereview.appspot.com/11416044/diff/1/tests/com/google/caja/plugin/e...
File tests/com/google/caja/plugin/es53-test-domado-events-guest.html (right):

https://codereview.appspot.com/11416044/diff/1/tests/com/google/caja/plugin/e...
tests/com/google/caja/plugin/es53-test-domado-events-guest.html:940: if
(directAccess.feralFeatureTest(event, 'key') && event.key != '') {
On 2013/07/17 16:44:03, kpreid2 wrote:
> Use directAccess.getFeralProperty(event, 'key') instead so that the test
doesn't
> pass if tame event.key is always ''.
> 
> !== not !=

Done.

[felix8a, 2013-07-17 16:52:39]

On 2013/07/17 16:52:12, felix8a wrote:
>
https://codereview.appspot.com/11416044/diff/1/tests/com/google/caja/plugin/e...
> File tests/com/google/caja/plugin/es53-test-domado-events-guest.html (right):
> 
>
https://codereview.appspot.com/11416044/diff/1/tests/com/google/caja/plugin/e...
> tests/com/google/caja/plugin/es53-test-domado-events-guest.html:940: if
> (directAccess.feralFeatureTest(event, 'key') && event.key != '') {
> On 2013/07/17 16:44:03, kpreid2 wrote:
> > Use directAccess.getFeralProperty(event, 'key') instead so that the test
> doesn't
> > pass if tame event.key is always ''.
> > 
> > !== not !=
> 
> Done.

oops, wait. snapshot is wrong

[felix8a, 2013-07-17 16:55:42]

keyboard events are supposed to have an event.key property, which is
the new hotness obsoleting event.keyCode. firefox doesn't implement
event.key yet, and different versions of firefox fail to implement
event.key in different ways.

firefox 22 doesn't have an event.key property.
firefox 23 and 24 has an event.key property and it seems to be always ''.
the '' value is causing a spurious browser test failure.

this mutes that failure.

this fixes https://code.google.com/p/google-caja/issues/detail?id=1805

[felix8a, 2013-07-17 16:56:08]

ok, new snapshot ready

[kpreid2, 2013-07-17 16:56:49]

LGTM

[felix8a, 2013-07-17 16:58:21]

@r5496