support mobility with buildings

[Tom Henderson, 2013-07-24 14:06:08]

Just some minor comments to address before merge.  Also, update CHANGES.html and
RELEASE_NOTES.

https://codereview.appspot.com/11374043/diff/1/src/buildings/helper/buildings...
File src/buildings/helper/buildings-helper.h (right):

https://codereview.appspot.com/11374043/diff/1/src/buildings/helper/buildings...
src/buildings/helper/buildings-helper.h:58: * Update the MobilityBuildingInfo
according to the buildings created
suggest a bit more documentation about what is done in this method; the term
"consistent" is not that explanatory.

https://codereview.appspot.com/11374043/diff/1/src/mobility/model/steady-stat...
File src/mobility/model/steady-state-random-waypoint-mobility-model.h (right):

https://codereview.appspot.com/11374043/diff/1/src/mobility/model/steady-stat...
src/mobility/model/steady-state-random-waypoint-mobility-model.h:77: double m_z;
The class doxygen for this class needs to be updated to account for the Z-axis
mobility (and it states that it is 2D-- needs to be updated to 3D).

[Tom Henderson, 2013-07-24 14:14:33]

modification of previous comment

https://codereview.appspot.com/11374043/diff/1/src/mobility/model/steady-stat...
File src/mobility/model/steady-state-random-waypoint-mobility-model.h (right):

https://codereview.appspot.com/11374043/diff/1/src/mobility/model/steady-stat...
src/mobility/model/steady-state-random-waypoint-mobility-model.h:77: double m_z;
On 2013/07/24 14:06:08, Tom Henderson wrote:
> The class doxygen for this class needs to be updated to account for the Z-axis
> mobility (and it states that it is 2D-- needs to be updated to 3D).

More precisely, I guess it is better to keep the documentation that it is 2D but
allows users to optionally set a Z-axis position that is not considered in the
motion pattern.

[Nicola Baldo, 2013-07-29 12:02:09]

https://codereview.appspot.com/11374043/diff/1/src/buildings/helper/buildings...
File src/buildings/helper/buildings-helper.h (right):

https://codereview.appspot.com/11374043/diff/1/src/buildings/helper/buildings...
src/buildings/helper/buildings-helper.h:58: * Update the MobilityBuildingInfo
according to the buildings created
On 2013/07/24 14:06:08, Tom Henderson wrote:
> suggest a bit more documentation about what is done in this method; the term
> "consistent" is not that explanatory.

I've added a more descriptive explanation, though I wonder if it would be better
to also rename the method to MakeAllMobilityModelsConsistent, or perhaps
MakeAllBuildingInfoConsistent to reflect the change with the latest patch (note
that the naming of the method predates the patch).

https://codereview.appspot.com/11374043/diff/1/src/mobility/model/steady-stat...
File src/mobility/model/steady-state-random-waypoint-mobility-model.h (right):

https://codereview.appspot.com/11374043/diff/1/src/mobility/model/steady-stat...
src/mobility/model/steady-state-random-waypoint-mobility-model.h:77: double m_z;
On 2013/07/24 14:14:34, Tom Henderson wrote:
> On 2013/07/24 14:06:08, Tom Henderson wrote:
> > The class doxygen for this class needs to be updated to account for the
Z-axis
> > mobility (and it states that it is 2D-- needs to be updated to 3D).
> 
> More precisely, I guess it is better to keep the documentation that it is 2D
but
> allows users to optionally set a Z-axis position that is not considered in the
> motion pattern.

Done.