Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(286)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 11372043: LENA M6+M7

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by Nicola Baldo
Modified:
11 years, 9 months ago
Reviewers:
Tom Henderson
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+5095 lines, -1150 lines) Patch
M src/lte/AUTHORS View 2 chunks +11 lines, -11 lines 0 comments Download
M src/lte/RELEASE_NOTES View 1 chunk +8 lines, -0 lines 0 comments Download
M src/lte/doc/Makefile View 2 chunks +3 lines, -1 line 0 comments Download
M src/lte/doc/source/conf.py View 1 chunk +1 line, -1 line 0 comments Download
M src/lte/doc/source/figures/MCS_13_16.pdf View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_13_16.png View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_17_20.pdf View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_17_20.png View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_1_4.pdf View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_1_4.png View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_21_24.pdf View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_21_24.png View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_25_28.pdf View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_25_28.png View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_29_29.pdf View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_29_29.png View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_5_8.pdf View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_5_8.png View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_9_12.pdf View Binary file 0 comments Download
M src/lte/doc/source/figures/MCS_9_12.png View Binary file 0 comments Download
M src/lte/doc/source/figures/lte-enb-rrc-states.dot View 2 chunks +4 lines, -2 lines 0 comments Download
A src/lte/doc/source/figures/lte-handover-algorithm.dot View 1 chunk +21 lines, -0 lines 0 comments Download
M src/lte/doc/source/lte-design.rst View 5 chunks +151 lines, -23 lines 2 comments Download
M src/lte/doc/source/lte-references.rst View 1 chunk +4 lines, -0 lines 0 comments Download
M src/lte/doc/source/lte-testing.rst View 5 chunks +66 lines, -14 lines 0 comments Download
M src/lte/doc/source/lte-user.rst View 5 chunks +56 lines, -12 lines 2 comments Download
M src/lte/examples/lena-cqi-threshold.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/lte/examples/lena-dual-stripe.cc View 12 chunks +91 lines, -38 lines 0 comments Download
M src/lte/examples/lena-fading.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/lte/examples/lena-profiling.cc View 5 chunks +7 lines, -3 lines 0 comments Download
M src/lte/examples/lena-rem.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/lte/examples/lena-rem-sector-antenna.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M src/lte/examples/lena-simple.cc View 2 chunks +5 lines, -2 lines 0 comments Download
A src/lte/examples/lena-x2-handover-measures.cc View 1 chunk +257 lines, -0 lines 0 comments Download
M src/lte/examples/wscript View 1 chunk +3 lines, -0 lines 0 comments Download
M src/lte/helper/epc-helper.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/lte/helper/lte-helper.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/lte/helper/lte-helper.cc View 16 chunks +48 lines, -401 lines 0 comments Download
M src/lte/helper/lte-stats-calculator.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/lte/helper/lte-stats-calculator.cc View 2 chunks +178 lines, -0 lines 0 comments Download
M src/lte/helper/mac-stats-calculator.h View 1 chunk +35 lines, -0 lines 0 comments Download
M src/lte/helper/mac-stats-calculator.cc View 1 chunk +68 lines, -0 lines 0 comments Download
M src/lte/helper/phy-rx-stats-calculator.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/lte/helper/phy-rx-stats-calculator.cc View 3 chunks +45 lines, -2 lines 0 comments Download
M src/lte/helper/phy-stats-calculator.h View 1 chunk +38 lines, -0 lines 0 comments Download
M src/lte/helper/phy-stats-calculator.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M src/lte/helper/phy-tx-stats-calculator.h View 1 chunk +20 lines, -0 lines 0 comments Download
M src/lte/helper/phy-tx-stats-calculator.cc View 2 chunks +46 lines, -1 line 0 comments Download
M src/lte/helper/radio-environment-map-helper.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/lte/helper/radio-environment-map-helper.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/lte/model/fdbet-ff-mac-scheduler.cc View 6 chunks +27 lines, -11 lines 0 comments Download
M src/lte/model/fdmt-ff-mac-scheduler.cc View 6 chunks +27 lines, -11 lines 0 comments Download
M src/lte/model/fdtbfq-ff-mac-scheduler.cc View 6 chunks +27 lines, -9 lines 0 comments Download
M src/lte/model/lte-common.h View 1 chunk +68 lines, -0 lines 0 comments Download
M src/lte/model/lte-common.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M src/lte/model/lte-control-messages.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-mac.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/lte/model/lte-enb-phy.cc View 2 chunks +40 lines, -3 lines 0 comments Download
M src/lte/model/lte-enb-rrc.h View 8 chunks +100 lines, -1 line 0 comments Download
M src/lte/model/lte-enb-rrc.cc View 19 chunks +344 lines, -22 lines 0 comments Download
M src/lte/model/lte-interference.cc View 3 chunks +12 lines, -17 lines 0 comments Download
M src/lte/model/lte-mi-error-model.cc View 4 chunks +18 lines, -18 lines 0 comments Download
M src/lte/model/lte-rlc-um.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/model/lte-rrc-header.cc View 27 chunks +320 lines, -189 lines 0 comments Download
M src/lte/model/lte-rrc-sap.h View 39 chunks +190 lines, -122 lines 0 comments Download
M src/lte/model/lte-spectrum-phy.h View 5 chunks +29 lines, -5 lines 0 comments Download
M src/lte/model/lte-spectrum-phy.cc View 7 chunks +33 lines, -4 lines 0 comments Download
M src/lte/model/lte-spectrum-signal-parameters.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/lte/model/lte-spectrum-signal-parameters.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/lte/model/lte-ue-cphy-sap.h View 3 chunks +30 lines, -1 line 0 comments Download
M src/lte/model/lte-ue-mac.cc View 1 chunk +18 lines, -3 lines 0 comments Download
M src/lte/model/lte-ue-phy.h View 5 chunks +40 lines, -0 lines 0 comments Download
M src/lte/model/lte-ue-phy.cc View 12 chunks +176 lines, -45 lines 0 comments Download
M src/lte/model/lte-ue-rrc.h View 4 chunks +45 lines, -0 lines 0 comments Download
M src/lte/model/lte-ue-rrc.cc View 5 chunks +635 lines, -2 lines 0 comments Download
M src/lte/model/pf-ff-mac-scheduler.cc View 6 chunks +26 lines, -9 lines 0 comments Download
M src/lte/model/pss-ff-mac-scheduler.cc View 6 chunks +27 lines, -9 lines 0 comments Download
M src/lte/model/rr-ff-mac-scheduler.cc View 10 chunks +32 lines, -11 lines 0 comments Download
M src/lte/model/tdbet-ff-mac-scheduler.cc View 6 chunks +27 lines, -11 lines 0 comments Download
M src/lte/model/tdmt-ff-mac-scheduler.cc View 6 chunks +27 lines, -11 lines 0 comments Download
M src/lte/model/tdtbfq-ff-mac-scheduler.cc View 6 chunks +27 lines, -9 lines 0 comments Download
M src/lte/model/trace-fading-loss-model.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/lte/model/trace-fading-loss-model.cc View 4 chunks +22 lines, -4 lines 0 comments Download
M src/lte/model/tta-ff-mac-scheduler.cc View 6 chunks +27 lines, -11 lines 0 comments Download
M src/lte/test/lte-test-downlink-sinr.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-harq.cc View 5 chunks +12 lines, -8 lines 0 comments Download
M src/lte/test/lte-test-mimo.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M src/lte/test/lte-test-pathloss-model.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/lte/test/lte-test-pathloss-model.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M src/lte/test/lte-test-pf-ff-mac-scheduler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/test/lte-test-phy-error-model.cc View 7 chunks +14 lines, -9 lines 0 comments Download
M src/lte/test/lte-test-pss-ff-mac-scheduler.cc View 6 chunks +31 lines, -31 lines 0 comments Download
A src/lte/test/lte-test-ue-measurements.h View 1 chunk +72 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-ue-measurements.cc View 1 chunk +265 lines, -0 lines 0 comments Download
A src/lte/test/reference/lte_link_budget_x2_handover_measures.m View 1 chunk +54 lines, -0 lines 0 comments Download
A src/lte/test/reference/lte_ue_measurements.m View 1 chunk +133 lines, -0 lines 0 comments Download
M src/lte/test/test-asn1-encoding.cc View 2 chunks +59 lines, -6 lines 0 comments Download
M src/lte/test/test-lte-epc-e2e-data.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lte/test/test-lte-x2-handover.cc View 5 chunks +17 lines, -15 lines 0 comments Download
A src/lte/test/test-lte-x2-handover-measures.cc View 1 chunk +667 lines, -0 lines 0 comments Download
M src/lte/wscript View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Tom Henderson
I just had a few documentation comments; only scanned a few files of the implementation ...
11 years, 9 months ago (2013-07-24 13:34:49 UTC) #1
Nicola Baldo
11 years, 9 months ago (2013-07-29 11:27:05 UTC) #2 
Hi Tom, 

thanks for your comments, I just fixed them in changeset 169a01a864de

https://codereview.appspot.com/11372043/diff/1/src/lte/doc/source/lte-design.rst
File src/lte/doc/source/lte-design.rst (right):

https://codereview.appspot.com/11372043/diff/1/src/lte/doc/source/lte-design....
src/lte/doc/source/lte-design.rst:2088: neighbour eNB. The handover will really
triggered depending on the
On 2013/07/24 13:34:49, Tom Henderson wrote:
> really be triggered?

Done.

https://codereview.appspot.com/11372043/diff/1/src/lte/doc/source/lte-user.rst
File src/lte/doc/source/lte-user.rst (right):

https://codereview.appspot.com/11372043/diff/1/src/lte/doc/source/lte-user.rs...
src/lte/doc/source/lte-user.rst:568: Ptr<BuildingsMobilityModel> mm1 =
enbNodes.Get (1)->GetObject<ConstantPositionMobilityModel> ();
On 2013/07/24 13:34:49, Tom Henderson wrote:
> Need to update the lhs of the above equations.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b