Remove unsupported character codes from XML response

Remove unsupported character codes from XML response

b/16505221 Binary character references failed to parse in SP connector v4


Reference for unused chars
http://www.w3.org/MarkUp/html-spec/html-spec_13.html

[pjo, 2014-07-24 22:45:08]

Thank you

https://codereview.appspot.com/113520043/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/sharepoint/SiteDataClient.java (right):

https://codereview.appspot.com/113520043/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/sharepoint/SiteDataClient.java:80:
"&#(0[0-8]|(1[12|4-9]|2[0-9]|3[01])|(1(2[7-9]|[3-5][0-9])));");
why is there a pipe between 12 and 4-9?

should there be parentheses around 0[0-8]? (yes, not needed but should there be)

maybe build up the expression more gradually for the reader?

pat1 = "0[0-8]"; // 00 - 08
pat2 = "1[124-9]|2[0-9]|3[01]"; // 11,12,14-31
pat3 = "1(2[7-9]|[3-5][0-9])"; // 127-159

full = "&#(" + pat1 + "|" + pat2 + "|" + pat3 + ");";

[JohnL, 2014-07-25 01:55:38]

Fwiw.

John L

https://codereview.appspot.com/113520043/diff/1/src/com/google/enterprise/ada...
File src/com/google/enterprise/adaptor/sharepoint/SiteDataClient.java (right):

https://codereview.appspot.com/113520043/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/sharepoint/SiteDataClient.java:78: */
Indent one more space.

https://codereview.appspot.com/113520043/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/sharepoint/SiteDataClient.java:80:
"&#(0[0-8]|(1[12|4-9]|2[0-9]|3[01])|(1(2[7-9]|[3-5][0-9])));");
On 2014/07/24 22:45:08, pjo wrote:
> why is there a pipe between 12 and 4-9?
> 
> should there be parentheses around 0[0-8]? (yes, not needed but should there
be)
> 
> maybe build up the expression more gradually for the reader?
> 
> pat1 = "0[0-8]"; // 00 - 08
> pat2 = "1[124-9]|2[0-9]|3[01]"; // 11,12,14-31
> pat3 = "1(2[7-9]|[3-5][0-9])"; // 127-159
> 
> full = "&#(" + pat1 + "|" + pat2 + "|" + pat3 + ");";

Not trying to sell it, but using the ignored whitespace options could also help
readability.

https://codereview.appspot.com/113520043/diff/1/src/com/google/enterprise/ada...
src/com/google/enterprise/adaptor/sharepoint/SiteDataClient.java:306: //
Unsuppoerted character codes such as Unit seprator  sometimes
"Unsuppoerted" => "Unsupported", "seprator" => "separator"

[pjo, 2014-07-25 18:02:24]

thank you

https://codereview.appspot.com/113520043/diff/20001/src/com/google/enterprise...
File src/com/google/enterprise/adaptor/sharepoint/SiteDataClient.java (right):

https://codereview.appspot.com/113520043/diff/20001/src/com/google/enterprise...
src/com/google/enterprise/adaptor/sharepoint/SiteDataClient.java:78: private
static final String UNUSED_CHAR_RANGE3 = "1[4-9]|2[0-9]|3[01]";
dont these need to be in parens?
otherwsie they are on same level as pipes
in BINARY_UNYUSED_CHAR_PATTERN?

[Tanmay Vartak, 2014-07-25 18:19:30]

On 2014/07/25 18:02:24, pjo wrote:
> thank you
> 
>
https://codereview.appspot.com/113520043/diff/20001/src/com/google/enterprise...
> File src/com/google/enterprise/adaptor/sharepoint/SiteDataClient.java (right):
> 
>
https://codereview.appspot.com/113520043/diff/20001/src/com/google/enterprise...
> src/com/google/enterprise/adaptor/sharepoint/SiteDataClient.java:78: private
> static final String UNUSED_CHAR_RANGE3 = "1[4-9]|2[0-9]|3[01]";
> dont these need to be in parens?
> otherwsie they are on same level as pipes
> in BINARY_UNYUSED_CHAR_PATTERN?

I think this still works.
This will be final regex :
&#((0[0-8]|1[12]|1[4-9]|2[0-9]|3[01]|1(2[7-9]|[3-5][0-9]));

As per above regex we still have all ranges defined as required. But just for
clarity I will add parens for each range.

[pjo, 2014-07-25 23:02:24]

LGTM.  Thank you