|
|
Add support for icons using new api endpoint.
- The charmworld backend will determine logic for icon display
- Change the file helper to an icon helper and update to fetch that in all
icon locations
- Update tests for the new helper
- Move the mock logic for that helpers into the module itself since it's
responsible for it. A little hacky, but nicer than repeating the code 10x in
any test that might output a charm icon link.
Note: this cannot land until the charmworld changes that add the api lands.
This is qa'd against the branch of charmworld to verify it works.
https://code.launchpad.net/~rharding/juju-gui/use-icon-api/+merge/175019
(do not edit description out of merge proposal)
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+113 lines, -173 lines) |
Patch |
 |
A |
[revision details]
|
View
|
1
2
3
4
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
app/models/charm.js
|
View
|
1
2
3
|
2 chunks |
+0 lines, -26 lines |
0 comments
|
Download
|
|
M |
app/store/charm.js
|
View
|
|
1 chunk |
+18 lines, -0 lines |
0 comments
|
Download
|
|
M |
app/subapps/browser/browser.js
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
app/subapps/browser/templates/browser_charm.handlebars
|
View
|
1
2
3
|
1 chunk |
+1 line, -12 lines |
0 comments
|
Download
|
|
M |
app/templates/charm-token.handlebars
|
View
|
1
2
3
|
1 chunk |
+3 lines, -24 lines |
0 comments
|
Download
|
|
M |
app/widgets/charm-token.js
|
View
|
1
2
3
4
|
2 chunks |
+1 line, -10 lines |
0 comments
|
Download
|
|
M |
test/index.html
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
test/test_browser_charm_details.js
|
View
|
1
2
3
4
|
4 chunks |
+6 lines, -26 lines |
0 comments
|
Download
|
|
M |
test/test_browser_editorial.js
|
View
|
1
2
3
4
|
3 chunks |
+8 lines, -13 lines |
0 comments
|
Download
|
|
M |
test/test_browser_search_view.js
|
View
|
1
2
3
4
|
3 chunks |
+8 lines, -11 lines |
0 comments
|
Download
|
|
M |
test/test_charm_container.js
|
View
|
1
2
3
4
|
3 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
|
M |
test/test_charm_store.js
|
View
|
|
2 chunks |
+13 lines, -1 line |
0 comments
|
Download
|
|
M |
test/test_charm_token.js
|
View
|
1
2
3
4
|
3 chunks |
+8 lines, -41 lines |
0 comments
|
Download
|
|
M |
test/test_charm_token_drag_and_drop.js
|
View
|
1
2
3
4
|
3 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
|
M |
test/test_charm_view.js
|
View
|
1
2
3
4
|
3 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
|
M |
test/test_service_module.js
|
View
|
1
2
3
4
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
test/utils.js
|
View
|
1
2
3
4
|
2 chunks |
+18 lines, -0 lines |
0 comments
|
Download
|
Total messages: 7
|
