Adds support for the nested blocks to BlockInitialize.

Adds support for the nested blocks to BlockInitialize.

BUG=
R=chrisha@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=2189

[Sébastien Marchand, 2014-07-22 22:38:32]

PTAL.

[chrisha, 2014-07-23 15:13:17]

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/block.h
File syzygy/agent/asan/block.h (right):

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/block.h...
syzygy/agent/asan/block.h:204: bool is_nested;
I'd add this to to the end of the BlockInfo struct entirely, rather than placing
it here.

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/block_u...
File syzygy/agent/asan/block_unittest.cc (right):

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/block_u...
syzygy/agent/asan/block_unittest.cc:345: EXPECT_TRUE(recovered_info.is_nested);
Shouldn't we add equivalent EXPECT_FALSE lines on other existing tests for
non-nested blocks?

[chrisha, 2014-07-23 15:13:46]

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/asan_he...
File syzygy/agent/asan/asan_heap.h (right):

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/asan_he...
syzygy/agent/asan/asan_heap.h:258: bool is_nested,
This change can come when we switch to using the new Block style? As is it
doesn't yet do anything...

[Sébastien Marchand, 2014-07-23 16:40:20]

Thanks, PTAnL.

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/asan_he...
File syzygy/agent/asan/asan_heap.h (right):

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/asan_he...
syzygy/agent/asan/asan_heap.h:258: bool is_nested,
On 2014/07/23 15:13:45, chrisha wrote:
> This change can come when we switch to using the new Block style? As is it
> doesn't yet do anything...

Done.

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/block.h
File syzygy/agent/asan/block.h (right):

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/block.h...
syzygy/agent/asan/block.h:204: bool is_nested;
On 2014/07/23 15:13:17, chrisha wrote:
> I'd add this to to the end of the BlockInfo struct entirely, rather than
placing
> it here.

Yeah, I wasn't sure how to organize this structure, my idea was to group things
like this:

struct BlockInfo {
  // General information: Size, is_nested...

  // Layout information, in order:
  //   - header info
  //   - body info
  //   - trailer info
};

But the page information doesn't really fit in this layout.

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/block_u...
File syzygy/agent/asan/block_unittest.cc (right):

https://codereview.appspot.com/113420043/diff/20001/syzygy/agent/asan/block_u...
syzygy/agent/asan/block_unittest.cc:345: EXPECT_TRUE(recovered_info.is_nested);
On 2014/07/23 15:13:17, chrisha wrote:
> Shouldn't we add equivalent EXPECT_FALSE lines on other existing tests for
> non-nested blocks?

This is already checked in the IsValidBlockImpl function, this seem to be the
function where check the validity of the BlockInfo structure.

[chrisha, 2014-07-23 17:35:23]

lgtm

[Sébastien Marchand, 2014-07-23 17:36:59]

Thanks, committing.

[Sébastien Marchand, 2014-07-23 17:40:25]

Thanks, committing.

[Sébastien Marchand, 2014-07-23 17:41:03]

Committed patchset #2 manually as r2189.