Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(633)

Issue 1134042: siginterrupt with flag=False is reset when signal received (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by jcalderone
Modified:
7 years, 7 months ago
Base URL:
http://svn.python.org/view/*checkout*/python/trunk/
Visibility:
Public.

Description

http://bugs.python.org/issue8354

Patch Set 1 #

Total comments: 10

Patch Set 2 : address all previously raised review points #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -17 lines) Patch
M Lib/test/test_signal.py View 1 1 chunk +74 lines, -17 lines 0 comments Download
M Modules/signalmodule.c View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Python/pythonrun.c View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Antoine Pitrou
http://codereview.appspot.com/1134042/diff/1/3 File Lib/test/test_signal.py (right): http://codereview.appspot.com/1134042/diff/1/3#newcode267 Lib/test/test_signal.py:267: Just a small style thing: don't put two blank ...
7 years, 7 months ago (2010-05-07 17:52:27 UTC) #1
Benjamin
Looks mostly perfect to me. http://codereview.appspot.com/1134042/diff/1/3 File Lib/test/test_signal.py (right): http://codereview.appspot.com/1134042/diff/1/3#newcode270 Lib/test/test_signal.py:270: the read is interrupted ...
7 years, 7 months ago (2010-05-07 18:19:06 UTC) #2
jcalderone
7 years, 7 months ago (2010-05-07 22:49:07 UTC) #3
Thanks very much for the reviews!  I think I've addressed all points.

http://codereview.appspot.com/1134042/diff/1/3
File Lib/test/test_signal.py (right):

http://codereview.appspot.com/1134042/diff/1/3#newcode267
Lib/test/test_signal.py:267: 
On 2010/05/07 17:52:27, Antoine Pitrou wrote:
> Just a small style thing: don't put two blank lines between each two methods.
> One line is enough.
> 

Done.

http://codereview.appspot.com/1134042/diff/1/3#newcode270
Lib/test/test_signal.py:270: the read is interrupted by the signal and raises an
exception, False
On 2010/05/07 18:19:07, Benjamin wrote:
> Having a comma before False creates a run on sentence. Make a new sentence or
> use a conjunction.

Done.

http://codereview.appspot.com/1134042/diff/1/3#newcode281
Lib/test/test_signal.py:281: cb()
On 2010/05/07 17:52:27, Antoine Pitrou wrote:
> Why can't cb be called by the calling method instead? Is it important that it
> gets called after os.pipe()?
> 

You're right.  It can be called in the test_ methods.  It couldn't before I
refactored the signal call into the setUp method, but now it can.  Done.

http://codereview.appspot.com/1134042/diff/1/3#newcode333
Lib/test/test_signal.py:333: self.assertEquals(i, True)
On 2010/05/07 18:19:07, Benjamin wrote:
> assertTrue or assertIs would be better.

Done.

http://codereview.appspot.com/1134042/diff/1/4
File Modules/signalmodule.c (right):

http://codereview.appspot.com/1134042/diff/1/4#newcode202
Modules/signalmodule.c:202: /* If the handler was not set up with sigaction,
reinstall it.  See
On 2010/05/07 17:52:27, Antoine Pitrou wrote:
> You could add the issue number for reference.
> 

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d