siginterrupt with flag=False is reset when signal received

http://bugs.python.org/issue8354

[Antoine Pitrou, 2010-05-07 17:52:27]

http://codereview.appspot.com/1134042/diff/1/3
File Lib/test/test_signal.py (right):

http://codereview.appspot.com/1134042/diff/1/3#newcode267
Lib/test/test_signal.py:267: 
Just a small style thing: don't put two blank lines between each two methods.
One line is enough.

http://codereview.appspot.com/1134042/diff/1/3#newcode281
Lib/test/test_signal.py:281: cb()
Why can't cb be called by the calling method instead? Is it important that it
gets called after os.pipe()?

http://codereview.appspot.com/1134042/diff/1/4
File Modules/signalmodule.c (right):

http://codereview.appspot.com/1134042/diff/1/4#newcode202
Modules/signalmodule.c:202: /* If the handler was not set up with sigaction,
reinstall it.  See
You could add the issue number for reference.

[Benjamin, 2010-05-07 18:19:06]

Looks mostly perfect to me.

http://codereview.appspot.com/1134042/diff/1/3
File Lib/test/test_signal.py (right):

http://codereview.appspot.com/1134042/diff/1/3#newcode270
Lib/test/test_signal.py:270: the read is interrupted by the signal and raises an
exception, False
Having a comma before False creates a run on sentence. Make a new sentence or
use a conjunction.

http://codereview.appspot.com/1134042/diff/1/3#newcode333
Lib/test/test_signal.py:333: self.assertEquals(i, True)
assertTrue or assertIs would be better.

[jcalderone, 2010-05-07 22:49:07]

Thanks very much for the reviews!  I think I've addressed all points.

http://codereview.appspot.com/1134042/diff/1/3
File Lib/test/test_signal.py (right):

http://codereview.appspot.com/1134042/diff/1/3#newcode267
Lib/test/test_signal.py:267: 
On 2010/05/07 17:52:27, Antoine Pitrou wrote:
> Just a small style thing: don't put two blank lines between each two methods.
> One line is enough.
> 

Done.

http://codereview.appspot.com/1134042/diff/1/3#newcode270
Lib/test/test_signal.py:270: the read is interrupted by the signal and raises an
exception, False
On 2010/05/07 18:19:07, Benjamin wrote:
> Having a comma before False creates a run on sentence. Make a new sentence or
> use a conjunction.

Done.

http://codereview.appspot.com/1134042/diff/1/3#newcode281
Lib/test/test_signal.py:281: cb()
On 2010/05/07 17:52:27, Antoine Pitrou wrote:
> Why can't cb be called by the calling method instead? Is it important that it
> gets called after os.pipe()?
> 

You're right.  It can be called in the test_ methods.  It couldn't before I
refactored the signal call into the setUp method, but now it can.  Done.

http://codereview.appspot.com/1134042/diff/1/3#newcode333
Lib/test/test_signal.py:333: self.assertEquals(i, True)
On 2010/05/07 18:19:07, Benjamin wrote:
> assertTrue or assertIs would be better.

Done.

http://codereview.appspot.com/1134042/diff/1/4
File Modules/signalmodule.c (right):

http://codereview.appspot.com/1134042/diff/1/4#newcode202
Modules/signalmodule.c:202: /* If the handler was not set up with sigaction,
reinstall it.  See
On 2010/05/07 17:52:27, Antoine Pitrou wrote:
> You could add the issue number for reference.
> 

Done.