Change the default root-dir to be in $HOME

Change the default root-dir to be in $HOME

Instead of having the root-dir in /usr/lib/juju, make it
in ~/.juju (well, $JUJU_HOME) by default.  The root dir
is now the environment name under the ~/.juju dir.

https://code.launchpad.net/~thumper/juju-core/local-default-root-dir/+merge/174908

Requires: https://code.launchpad.net/~thumper/juju-core/local-sudo-caller/+merge/174904

(do not edit description out of merge proposal)

[thumper, 2013-07-16 03:28:17]

Please take a look.

[jtv.canonical, 2013-07-16 04:13:58]

LGTM but for one thing that worries me: is this about /usr/lib/juju or about
/var/lib/juju?

https://codereview.appspot.com/11319044/diff/1/environs/local/environ_test.go
File environs/local/environ_test.go (left):

https://codereview.appspot.com/11319044/diff/1/environs/local/environ_test.go...
environs/local/environ_test.go:21: func (*environSuite)
TestOpenFailsWithoutDirs(c *gc.C) {

This test's name may need changing now.

https://codereview.appspot.com/11319044/diff/1/environs/local/environprovider...
File environs/local/environprovider_test.go (left):

https://codereview.appspot.com/11319044/diff/1/environs/local/environprovider...
environs/local/environprovider_test.go:16: restoreDataDir func()

You're removing the overriding of DataDir here — but be aware that that is *not*
the old /usr/lib/juju that you're replacing here.  This one is about
/var/lib/juju.  So you may still need both.

[fwereade, 2013-07-16 11:01:44]

LGTM

[thumper, 2013-07-16 22:00:59]

https://codereview.appspot.com/11319044/diff/1/environs/local/environ_test.go
File environs/local/environ_test.go (left):

https://codereview.appspot.com/11319044/diff/1/environs/local/environ_test.go...
environs/local/environ_test.go:21: func (*environSuite)
TestOpenFailsWithoutDirs(c *gc.C) {
On 2013/07/16 04:13:58, jtv.canonical wrote:
> 
> This test's name may need changing now.

Done.

https://codereview.appspot.com/11319044/diff/1/environs/local/environprovider...
File environs/local/environprovider_test.go (left):

https://codereview.appspot.com/11319044/diff/1/environs/local/environprovider...
environs/local/environprovider_test.go:16: restoreDataDir func()
On 2013/07/16 04:13:58, jtv.canonical wrote:
> 
> You're removing the overriding of DataDir here — but be aware that that is
*not*
> the old /usr/lib/juju that you're replacing here.  This one is about
> /var/lib/juju.  So you may still need both.

Sorry about the confusing directory name.  I should have said /var/lib/juju, and
we don't actually use that now.