Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(520)

Issue 113110045: Split web developer tracing preset into web developer, and web developer with javascript (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by pdr1
Modified:
11 years, 6 months ago
Reviewers:
nduca, fmeawad, adamk
CC:
trace-viewer-review_googlegroups.com
Base URL:
http://trace-viewer.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add a preset for web developers that don't want javascript events This patch adds an additional trace preset to support web developers not interested in javascript tracing data (which can be large). BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M trace_viewer/about_tracing/record_selection_dialog.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
pdr1
11 years, 6 months ago (2014-07-15 02:30:07 UTC) #1
nduca
v8 instrumentation is big in size? or, intrusive? or... how does this compare to just ...
11 years, 6 months ago (2014-07-15 04:26:15 UTC) #2
adamk
I don't know if this is quite what I had in mind. Perhaps we need ...
11 years, 6 months ago (2014-07-15 15:12:35 UTC) #3
fmeawad
On 2014/07/15 15:12:35, adamk wrote: > I don't know if this is quite what I ...
11 years, 6 months ago (2014-07-15 21:53:28 UTC) #4
pdr1
11 years, 6 months ago (2014-07-20 16:45:50 UTC) #5
On 2014/07/15 21:53:28, fmeawad wrote:
> On 2014/07/15 15:12:35, adamk wrote:
> > I don't know if this is quite what I had in mind. Perhaps we need slightly
> more
> > fine-grained V8 tracing? At the moment, the V8 tracing fills up the buffer
in
> 2
> > or 3 seconds. This seems to be a recent change...
> 
> I have filed https://code.google.com/p/v8/issues/detail?id=3432 which tracks
the
> buffer filling quickly in V8.

I sent this off then left for a long vacation :/

It looks like this has been resolved on the v8 side. I'll confirm tomorrow, but
lets close this for now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b