Provides an extensible membraning system for objective taming-with-wrapping.

Fixes 1114.
Helps fix 1096 by creating an objective taming membrane.
Creates a clear distinction between pseudo-functions and other records.
The new functionality of taming system is not tested at all yet. Our
existing tests are running green. However, enough things changed that
I'm not at all confident I haven't broken something. I need careful
skeptical eyes -- the more the safer.

[Jasvir, 2009-10-01 23:07:55]

http://codereview.appspot.com/113048/diff/5001/6002
File src/com/google/caja/cajita.js (right):

http://codereview.appspot.com/113048/diff/5001/6002#newcode1091
Line 1091: * <li>If f has an AS_TAMED___() method, call it and then register
'tame' doesn't mark a function argument which has been markedInnocent callable. 
I think this is a bug.

http://codereview.appspot.com/113048/diff/5001/6002#newcode1775
Line 1775: if (isXo4a(func)) {
s/isXo4a/isXo4aFunc/

[MarkM, 2009-10-03 00:05:26]

After a day spent debugging with Jas, several bugs
were identified that I will fix. No one should spend any more effort reviewing
this until the next snapshot.

http://codereview.appspot.com/113048/diff/5001/6002
File src/com/google/caja/cajita.js (right):

http://codereview.appspot.com/113048/diff/5001/6002#newcode1091
Line 1091: * <li>If f has an AS_TAMED___() method, call it and then register
On 2009/10/01 23:07:55, jasvir wrote:
> 'tame' doesn't mark a function argument which has been markedInnocent
callable. 
> I think this is a bug.

Just for the record: This was a misinterpretation of the symptom of another bug,
rather than a bug itself. After a day spent debugging with Jas, several bugs
were identified that I will fix. No one should spend any more effort reviewing
this until the next snapshot.

[Jasvir, 2009-10-07 00:54:13]

http://codereview.appspot.com/113048/diff/8005/6026
File tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java
(right):

http://codereview.appspot.com/113048/diff/8005/6026#newcode445
Line 445: "function forbidden() { return arguments; }" +
This is an great stress test.  Please add a test for taming constructors to this
list.

[Jasvir, 2009-10-07 21:37:18]

http://codereview.appspot.com/113048/diff/6032/8009
File src/com/google/caja/cajita.js (right):

http://codereview.appspot.com/113048/diff/6032/8009#newcode1793
Line 1793: function markInnocent(func, opt_name) {
* Feature request: grantInnocent for marking innocent methods.

[Jasvir, 2009-10-09 23:38:47]

http://codereview.appspot.com/113048/diff/6032/8009
File src/com/google/caja/cajita.js (right):

http://codereview.appspot.com/113048/diff/6032/8009#newcode1217
Line 1217: function tameRecord(f) {
Given the almost identical nature of tameRecord and untameRecord, would it make
sense to have a private parameterized common method which tame and untame call.

http://codereview.appspot.com/113048/diff/6032/8009#newcode2553
Line 2553: 'rhinoException', 'javaException', // Possibly for Rhino?
Neither of these are particularly useful directly.  They contain
printStackTrace, getMessage etc methods which are in turn useful.

[MarkM, 2009-10-12 22:49:06]

http://codereview.appspot.com/113048/diff/8005/6026
File tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java
(right):

http://codereview.appspot.com/113048/diff/8005/6026#newcode445
Line 445: "function forbidden() { return arguments; }" +
On 2009/10/07 00:54:13, jasvir wrote:
> This is an great stress test.  Please add a test for taming constructors to
this
> list.

Done.

http://codereview.appspot.com/113048/diff/6032/8009
File src/com/google/caja/cajita.js (right):

http://codereview.appspot.com/113048/diff/6032/8009#newcode1217
Line 1217: function tameRecord(f) {
On 2009/10/09 23:38:47, jasvir wrote:
> Given the almost identical nature of tameRecord and 
> untameRecord, would it make sense to have a private 
> parameterized common method which tame and untame call.

The problem is how higher order the reader needs to be to follow the resulting
logic. I am able to think about the current code because "feral" and "tame" are
two distinct names sides of different kinds. Were I to abstract and
parameterize, even I as author would find it hard to follow. So I want to
relieve readers and reviewers of this confusion.

http://codereview.appspot.com/113048/diff/6032/8009#newcode1793
Line 1793: function markInnocent(func, opt_name) {
On 2009/10/07 21:37:18, jasvir wrote:
> * Feature request: grantInnocent for marking innocent methods.

Done. But for uniformity, it is called grantInnocentMethod.

http://codereview.appspot.com/113048/diff/6032/8009#newcode2553
Line 2553: 'rhinoException', 'javaException', // Possibly for Rhino?
On 2009/10/09 23:38:47, jasvir wrote:
> Neither of these are particularly useful directly.  They contain
> printStackTrace, getMessage etc methods which are in turn useful.

Done -- removed.

[Jasvir, 2009-10-13 04:04:00]

LGTM