Issue 11294043: Get rid of unnecessary ES53-only checks for non-CSS2.1 colors.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11294043: Get rid of unnecessary ES53-only checks for non-CSS2.1 colors. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by MikeSamuel

Modified:
12 years, 8 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

CSSRewriter used to convert color keywords that were not recognized by a strict interpretation of CSS2.1. This was never done client-side, and the messages reported are now of marginal value. Removing this has the nice side-effect of making CssRewriter completely independent of the CSS schema. ---- Submitted at r5492

Patch Set 1 #

Patch Set 2 : Get rid of unnecessary ES53-only checks for non-CSS2.1 colors. #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -274 lines)			Patch
M	src/com/google/caja/parser/js/Parser.java	View		4 chunks	+6 lines, -4 lines	0 comments	Download
M	src/com/google/caja/plugin/BuildServiceImplementation.java	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/CssRewriter.java	View		14 chunks	+15 lines, -204 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/ValidateCssStage.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/plugin/templates/HtmlAttributeRewriter.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/parser/quasiliteral/RewriterTestCase.java	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	tests/com/google/caja/plugin/CssDynamicExpressionRewriterTest.java	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	tests/com/google/caja/plugin/CssRewriterTest.java	View		4 chunks	+3 lines, -24 lines	0 comments	Download
M	tests/com/google/caja/plugin/css-stylesheet-tests.js	View	1	1 chunk	+3 lines, -21 lines	0 comments	Download
M	tests/com/google/caja/plugin/templates/TemplateCompilerTest.java	View		3 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

MikeSamuel

CSSRewriter used to convert color keywords that were not recognized by a strict interpretation of ...

12 years, 8 months ago (2013-07-15 19:25:58 UTC) #2

lgtm

Expand All Messages | Collapse All Messages