Issue 112940044: Avoid string copying in json.cc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 112940044: Avoid string copying in json.cc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by Rouslan Solomakhin

Modified:
9 years, 10 months ago

Reviewers:
roubert (google), estade

CC:
lararennie, keghani, davinci_google, dbeaumont

Base URL:
https://libaddressinput.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Avoid string copying in json.cc. The following two methods: bool Json::HasStringValueForKey(const std::string& key) const; std::string Json::GetStringValueForKey(const std::string& key) const; have been replaced with a single method: bool Json::GetStringValueForKey(const std::string& key, std::string* value) const; to avoid copying possibly large strings. BUG=8 R=roubert@google.com Committed: https://code.google.com/p/libaddressinput/source/detail?r=303

Patch Set 1 #

Total comments: 1

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -89 lines)			Patch
M	cpp/src/preload_supplier.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	cpp/src/rule.cc	View	4 chunks	+29 lines, -48 lines	0 comments	Download
M	cpp/src/util/json.h	View	1 chunk	+5 lines, -9 lines	1 comment	Download
M	cpp/src/util/json.cc	View	1 chunk	+9 lines, -13 lines	0 comments	Download
M	cpp/test/util/json_test.cc	View	4 chunks	+25 lines, -17 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Rouslan Solomakhin

Committed patchset #1 manually as r303 (presubmit successful).

9 years, 10 months ago (2014-07-10 17:58:43 UTC) #3

estade

9 years, 10 months ago (2014-07-10 18:03:17 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/112940044/diff/1/cpp/src/util/json.h
File cpp/src/util/json.h (right):

https://codereview.appspot.com/112940044/diff/1/cpp/src/util/json.h#newcode55
cpp/src/util/json.h:55: bool HasDictionaryValueForKey(const std::string& key)
const;
I would change this API as well for consistency's sake, even though you're not
avoiding a Json copy.

Expand All Messages | Collapse All Messages