Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(428)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 112780043: Fixed #433 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by sksaurabhkathpalia
Modified:
10 years, 6 months ago
Reviewers:
thomas.j.waldmann
Visibility:
Public.

Description

Fixed #433

Patch Set 1 #

Patch Set 2 : Also fixed #452- Now user can also remove quicklink to nameless items #

Patch Set 3 : https://bitbucket.org/thomaswaldmann/moin-2.0/issue/433/user-actions-and-item-actions-bar-missing #

Total comments: 7

Patch Set 4 : Added comment for supplementation and changed exists variable to bool #

Patch Set 5 : Added coomment of TODO of adding fqname support to has_item #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M MoinMoin/storage/middleware/indexing.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M MoinMoin/themes/__init__.py View 1 2 3 4 5 chunks +21 lines, -20 lines 0 comments Download
M MoinMoin/themes/basic/templates/itemviews.html View 1 chunk +1 line, -1 line 0 comments Download
M MoinMoin/themes/basic/templates/layout.html View 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Thomas.J.Waldmann
https://codereview.appspot.com/112780043/diff/40001/MoinMoin/themes/__init__.py File MoinMoin/themes/__init__.py (right): https://codereview.appspot.com/112780043/diff/40001/MoinMoin/themes/__init__.py#newcode89 MoinMoin/themes/__init__.py:89: exists = flaskg.storage.get_item(**fqname.query) why do you call get_item for ...
10 years, 6 months ago (2014-07-12 16:00:43 UTC) #1
sksaurabhkathpalia
https://codereview.appspot.com/112780043/diff/40001/MoinMoin/themes/__init__.py File MoinMoin/themes/__init__.py (right): https://codereview.appspot.com/112780043/diff/40001/MoinMoin/themes/__init__.py#newcode89 MoinMoin/themes/__init__.py:89: exists = flaskg.storage.get_item(**fqname.query) On 2014/07/12 16:00:43, Thomas.J.Waldmann wrote: > ...
10 years, 6 months ago (2014-07-12 16:49:05 UTC) #2
Thomas.J.Waldmann
https://codereview.appspot.com/112780043/diff/40001/MoinMoin/themes/__init__.py File MoinMoin/themes/__init__.py (right): https://codereview.appspot.com/112780043/diff/40001/MoinMoin/themes/__init__.py#newcode89 MoinMoin/themes/__init__.py:89: exists = flaskg.storage.get_item(**fqname.query) well, you don't really use the ...
10 years, 6 months ago (2014-07-12 16:58:28 UTC) #3
sksaurabhkathpalia
https://codereview.appspot.com/112780043/diff/40001/MoinMoin/themes/__init__.py File MoinMoin/themes/__init__.py (right): https://codereview.appspot.com/112780043/diff/40001/MoinMoin/themes/__init__.py#newcode89 MoinMoin/themes/__init__.py:89: exists = flaskg.storage.get_item(**fqname.query) On 2014/07/12 16:58:27, Thomas.J.Waldmann wrote: > ...
10 years, 6 months ago (2014-07-12 17:02:20 UTC) #4
Thomas.J.Waldmann
10 years, 6 months ago (2014-07-16 17:22:13 UTC) #5 
https://codereview.appspot.com/112780043/diff/40001/MoinMoin/themes/__init__.py
File MoinMoin/themes/__init__.py (right):

https://codereview.appspot.com/112780043/diff/40001/MoinMoin/themes/__init__....
MoinMoin/themes/__init__.py:89: exists = flaskg.storage.get_item(**fqname.query)
ok, i see the indexing layer doesn't do much different in has_item (also does
get_item and bool()). But please add a TODO to here and to indexing.py:has_item
that it needs fixing for fqname support.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b