src/pkg/runtime/stack.c - Issue 112570044: code review 112570044: cmd/gc, runtime: treat slices and strings like pointers...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/runtime/stack.c

Issue 112570044: code review 112570044: cmd/gc, runtime: treat slices and strings like pointers... (Closed)

Patch Set: diff -r 6d5c17d94e9ddcd8ca450ac62f84cf9ddb436b65 https://code.google.com/p/go/ Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/runtime/stack.c

===================================================================

--- a/src/pkg/runtime/stack.c

+++ b/src/pkg/runtime/stack.c

@@ -592,19 +592,8 @@

break;

case BitsMultiWord:

switch(bv->data[(i+1) / (32 / BitsPerPointer)] >> ((i+1) * BitsPerPointer & 31) & 3) {

- case BitsString:

- // string referents are never on the stack, never need to be adjusted

- i++; // skip len

- break;

- case BitsSlice:

- p = scanp[i];

- if(minp <= p && p < maxp) {

- if(StackDebug >= 3)

- runtime·printf("adjust slice %p\n", p);

- scanp[i] = p + delta;

- }

- i += 2; // skip len, cap

- break;

+ default:

+ runtime·throw("unexpected garbage collection bits");

case BitsEface:

t = (Type*)scanp[i];

if(t != nil && ((t->kind & KindDirectIface) == 0 || (t->kind & KindNoPointers) == 0)) {

« no previous file with comments | « src/pkg/runtime/runtime.h ('k') | test/slice3.go » ('j') | no next file with comments »