code review 112570044: cmd/gc, runtime: treat slices and strings like pointers...

src/cmd/gc/typecheck.c

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 /*
  * type check the whole tree of an expression.
  * calculates expression types.
  * evaluates compile time constants.
  * marks variables that escape the local frame.
  * rewrites n->op to be more specific in some cases.
@@ skipping 506 matching lines @@
          */
         case OASOP:
                 ok |= Etop;
                 l = typecheck(&n->left, Erv);
                 checkassign(n->left);
                 r = typecheck(&n->right, Erv);
                 if(l->type == T || r->type == T)
                         goto error;
                 op = n->etype;
                 goto arith;
-
-        case OADDPTR:
-                ok |= Erv;
-                l = typecheck(&n->left, Erv);
-                r = typecheck(&n->right, Erv);
-                if(l->type == T || r->type == T)
-                        goto error;
-                if(l->type->etype != tptr)
-                        fatal("bad OADDPTR left type %E for %N", l->type->etype, n->left);
-                if(r->type->etype != TUINTPTR)
-                        fatal("bad OADDPTR right type %E for %N", r->type->etype, n->right);
-                n->type = types[tptr];
-                goto ret;
 
         case OADD:
         case OAND:
         case OANDAND:
         case OANDNOT:
         case ODIV:
         case OEQ:
         case OGE:
         case OGT:
         case OLE:
@@ skipping 2977 matching lines @@
         return 0;
 }
 
 void
 checkreturn(Node *fn)
 {
         if(fn->type->outtuple && fn->nbody != nil)
                 if(!isterminating(fn->nbody, 1))
                         yyerrorl(fn->endlineno, "missing return at end of function");
 }