Clean up dependencies.

Clean up dependencies.

- Remove unused #include statements.
- Add missing #include statements.
- Remove unused forward declarations.
- Add missing forward declarations.
- Group and sort #include and using statements consistently.

R=rouslan@chromium.org
BUG=

Committed: https://code.google.com/p/libaddressinput/source/detail?r=308

[Rouslan Solomakhin, 2014-07-18 23:34:15]

lgtm % 2 nits below:

https://codereview.appspot.com/112450046/diff/1/cpp/src/address_data.cc
File cpp/src/address_data.cc (left):

https://codereview.appspot.com/112450046/diff/1/cpp/src/address_data.cc#oldco...
cpp/src/address_data.cc:16: 
Should file.cc include file.h on the first line, followed by a newline? Or is
that a misconception of mine from a shallow understanding of the style? :-)

https://codereview.appspot.com/112450046/diff/1/cpp/test/supplier_test.cc
File cpp/test/supplier_test.cc (right):

https://codereview.appspot.com/112450046/diff/1/cpp/test/supplier_test.cc#new...
cpp/test/supplier_test.cc:19: #include <libaddressinput/downloader.h>
If you're not using Downloader below. Do you need to include it here?

[Rouslan Solomakhin, 2014-07-18 23:37:52]

Ok, hold off until I test on Windows please.



On Fri, Jul 18, 2014 at 4:34 PM, <rouslan@chromium.org> wrote:

> lgtm % 2 nits below:
>
>
> https://codereview.appspot.com/112450046/diff/1/cpp/src/address_data.cc
> File cpp/src/address_data.cc (left):
>
> https://codereview.appspot.com/112450046/diff/1/cpp/src/
> address_data.cc#oldcode16
> cpp/src/address_data.cc:16:
> Should file.cc include file.h on the first line, followed by a newline?
> Or is that a misconception of mine from a shallow understanding of the
> style? :-)
>
> https://codereview.appspot.com/112450046/diff/1/cpp/test/supplier_test.cc
> File cpp/test/supplier_test.cc (right):
>
> https://codereview.appspot.com/112450046/diff/1/cpp/test/
> supplier_test.cc#newcode19
> cpp/test/supplier_test.cc:19: #include <libaddressinput/downloader.h>
> If you're not using Downloader below. Do you need to include it here?
>
> https://codereview.appspot.com/112450046/
>

[roubert (google), 2014-07-18 23:44:03]

https://codereview.appspot.com/112450046/diff/1/cpp/src/address_data.cc
File cpp/src/address_data.cc (left):

https://codereview.appspot.com/112450046/diff/1/cpp/src/address_data.cc#oldco...
cpp/src/address_data.cc:16: 
On 2014/07/18 23:34:15, Rouslan Solomakhin wrote:
> Should file.cc include file.h on the first line, followed by a newline? Or is
> that a misconception of mine from a shallow understanding of the style? :-)

You're right, this was changed by mistake. Reverted.

https://codereview.appspot.com/112450046/diff/1/cpp/test/supplier_test.cc
File cpp/test/supplier_test.cc (right):

https://codereview.appspot.com/112450046/diff/1/cpp/test/supplier_test.cc#new...
cpp/test/supplier_test.cc:19: #include <libaddressinput/downloader.h>
On 2014/07/18 23:34:15, Rouslan Solomakhin wrote:
> If you're not using Downloader below. Do you need to include it here?

Right, this can be deleted too. Done.

[Rouslan Solomakhin, 2014-07-19 00:17:29]

Builds on Windows correctly, thanks!

[roubert (google), 2014-07-19 00:20:16]

Committed patchset #2 manually as r308 (presubmit successful).