Issue 11240043: Fixes Issue 1755: Need rewriteFunctionCalls mitigation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11240043: Fixes Issue 1755: Need rewriteFunctionCalls mitigation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by MarkM

Modified:
12 years, 7 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

See https://code.google.com/p/google-caja/issues/detail?id=1755

Patch Set 2 : Fixes Issue 1755: Need rewriteFunctionCalls mitigation #

Total comments: 2

Patch Set 3 : Fixes Issue 1755: Need rewriteFunctionCalls mitigation #

Patch Set 4 : Fixes Issue 1755: Need rewriteFunctionCalls mitigation #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -2 lines)			Patch
	M	src/com/google/caja/ses/mitigateGotchas.js	View	1 2 3	3 chunks	+49 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

MarkM

See https://code.google.com/p/google-caja/issues/detail?id=1755

12 years, 8 months ago (2013-07-13 20:56:27 UTC) #2

felix8a

lgtm https://codereview.appspot.com/11240043/diff/4001/src/com/google/caja/ses/mitigateGotchas.js File src/com/google/caja/ses/mitigateGotchas.js (right): https://codereview.appspot.com/11240043/diff/4001/src/com/google/caja/ses/mitigateGotchas.js#newcode67 src/com/google/caja/ses/mitigateGotchas.js:67: * its {@code this} bound to thw with's ...

12 years, 7 months ago (2013-07-14 19:16:20 UTC) #3

MarkM

See https://code.google.com/p/google-caja/issues/detail?id=1755

12 years, 7 months ago (2013-07-15 01:26:56 UTC) #4

MarkM

https://codereview.appspot.com/11240043/diff/4001/src/com/google/caja/ses/mitigateGotchas.js File src/com/google/caja/ses/mitigateGotchas.js (right): https://codereview.appspot.com/11240043/diff/4001/src/com/google/caja/ses/mitigateGotchas.js#newcode67 src/com/google/caja/ses/mitigateGotchas.js:67: * its {@code this} bound to thw with's scope ...

12 years, 7 months ago (2013-07-15 01:27:16 UTC) #5

MarkM

12 years, 7 months ago (2013-07-15 01:32:39 UTC) #6

See https://code.google.com/p/google-caja/issues/detail?id=1755

Expand All Messages | Collapse All Messages