ticket:10944: Add ByteBuffer support for properties classes.

ticket:10944: Add ByteBuffer support for properties classes.

Updates UBiDiProps, UCaseProps, UCharacterProperty and UPropertyAliases.

R=markus.icu@gmail.com

Committed: http://bugs.icu-project.org/trac/changeset/36038

[markus.icu, 2014-07-11 19:51:33]

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/impl/UBiDiProps.java (right):

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/impl/UBiDiProps.java:40: is.close();
should be in try..finally

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/impl/UCaseProps.java (right):

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/impl/UCaseProps.java:43: is.close();
should be in try..finally

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/impl/UCharacterProperty.java (right):

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/impl/UCharacterProperty.java:1245: is.close();
should be in try..finally

[markus.icu, 2014-07-11 19:54:34]

Actually, I just reminded myself that getByteBufferFromInputStream(InputStream
is) already closes the InputStream. So when that is being called, rather than
wrapping following code into try..finally for is.close(), please instead remove
the redundant is.close().

[roubert (google), 2014-07-14 15:04:54]

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/impl/UBiDiProps.java (right):

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/impl/UBiDiProps.java:40: is.close();
On 2014/07/11 19:51:33, markus.icu wrote:
> should be in try..finally

Done.

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/impl/UCaseProps.java (right):

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/impl/UCaseProps.java:43: is.close();
On 2014/07/11 19:51:33, markus.icu wrote:
> should be in try..finally

Done.

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
File main/classes/core/src/com/ibm/icu/impl/UCharacterProperty.java (right):

https://codereview.appspot.com/112020044/diff/1/main/classes/core/src/com/ibm...
main/classes/core/src/com/ibm/icu/impl/UCharacterProperty.java:1245: is.close();
On 2014/07/11 19:51:33, markus.icu wrote:
> should be in try..finally

Done.

[markus.icu, 2014-07-15 18:28:14]

LGTM

[roubert (google), 2014-07-15 20:56:05]

Committed patchset #3 manually as r36038 (presubmit successful).