Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(285)

Issue 11180043: Several features and fixes mostly in Domado. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by kpreid2
Modified:
12 years, 8 months ago
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Bugs: * Don't warn if event.view is missing or undefined (ssue 1713). * Explain navigator.cajaVersion in more detail (issue 1735). Features: * <input>.autofocus has a no-op setter (issue 1797). * Add <optgroup>.disabled and <optgroup>.label (issue 1802). * Add <form>.encoding as alias for <form>.enctype (issue 1794). * Add window.frames and window.frames.length (issue 1264). Other: * Add a generic host page available from brserve (issue 1684). * Rename 'Domita' to 'Domado' where applicable (issue 1400). * Remove 'domitaTrace' mechanism in Domado. * getUrlParam() understands + escapes. * In repairES5, added a bug link for PUSH_IGNORES_FROZEN in Chrome (issue 1756). @r5483

Patch Set 1 #

Total comments: 2

Patch Set 2 : Several features and fixes mostly in Domado. #

Patch Set 3 : Several features and fixes mostly in Domado. #

Total comments: 2

Patch Set 4 : Several features and fixes mostly in Domado. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -48 lines) Patch
M src/com/google/caja/demos/photon/container/photon.js View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/demos/trycaja/js/trycaja.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/com/google/caja/es53.js View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/plugin/CssRewriter.java View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/plugin/LinkStyleWhitelist.java View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/plugin/domado.js View 1 2 12 chunks +58 lines, -29 lines 0 comments Download
M src/com/google/caja/plugin/es53-frame-group.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/com/google/caja/plugin/templates/SafeCssMaker.java View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/ses/repairES5.js View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/browser-test-case.js View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/css-stylesheet-tests.js View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-dom-guest.html View 1 chunk +15 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-forms-guest.html View 1 chunk +39 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-special-guest.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/evil-twin.html View 1 chunk +1 line, -1 line 0 comments Download
A tests/com/google/caja/plugin/generic-host-page.html View 1 2 3 1 chunk +124 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/test-index.html View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/com/google/caja/plugin/third-party-tests.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12
kpreid2
12 years, 8 months ago (2013-07-11 19:14:37 UTC) #1
felix8a
lgtm https://codereview.appspot.com/11180043/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/11180043/diff/1/src/com/google/caja/plugin/domado.js#newcode2674 src/com/google/caja/plugin/domado.js:2674: // the IDL attribute is set to true." ...
12 years, 8 months ago (2013-07-11 21:25:50 UTC) #2
kpreid2
Bugs: * Don't warn if event.view is missing or undefined (ssue 1713). * Explain navigator.cajaVersion ...
12 years, 8 months ago (2013-07-11 21:42:48 UTC) #3
kpreid2
New snapshot adds copyright header and some features to generic-host-page.html and a bug link in ...
12 years, 8 months ago (2013-07-11 21:44:29 UTC) #4
kpreid2
Bugs: * Don't warn if event.view is missing or undefined (ssue 1713). * Explain navigator.cajaVersion ...
12 years, 8 months ago (2013-07-11 21:46:14 UTC) #5
kpreid2
https://codereview.appspot.com/11180043/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/11180043/diff/1/src/com/google/caja/plugin/domado.js#newcode2674 src/com/google/caja/plugin/domado.js:2674: // the IDL attribute is set to true." On ...
12 years, 8 months ago (2013-07-11 21:47:34 UTC) #6
felix8a
lgtm https://codereview.appspot.com/11180043/diff/10001/tests/com/google/caja/plugin/generic-host-page.html File tests/com/google/caja/plugin/generic-host-page.html (right): https://codereview.appspot.com/11180043/diff/10001/tests/com/google/caja/plugin/generic-host-page.html#newcode3 tests/com/google/caja/plugin/generic-host-page.html:3: - Copyright (C) 2010 Google Inc. 2013
12 years, 8 months ago (2013-07-11 22:35:50 UTC) #7
kpreid2
Bugs: * Don't warn if event.view is missing or undefined (ssue 1713). * Explain navigator.cajaVersion ...
12 years, 8 months ago (2013-07-11 22:39:54 UTC) #8
kpreid2
submitting https://codereview.appspot.com/11180043/diff/10001/tests/com/google/caja/plugin/generic-host-page.html File tests/com/google/caja/plugin/generic-host-page.html (right): https://codereview.appspot.com/11180043/diff/10001/tests/com/google/caja/plugin/generic-host-page.html#newcode3 tests/com/google/caja/plugin/generic-host-page.html:3: - Copyright (C) 2010 Google Inc. On 2013/07/11 ...
12 years, 8 months ago (2013-07-11 22:40:07 UTC) #9
MarkM
Please do remember to include me as a secondary reviewer on CLs which include ses/* ...
12 years, 8 months ago (2013-07-12 00:01:28 UTC) #10
kpreid2
On 2013/07/12 00:01:28, MarkM wrote: > Please do remember to include me as a secondary ...
12 years, 8 months ago (2013-07-12 00:02:58 UTC) #11
Mark S. Miller
12 years, 8 months ago (2013-07-12 00:05:11 UTC) #12
[+alan.karp]

;)


On Thu, Jul 11, 2013 at 5:02 PM, <kpreid.switchb.org@gmail.com> wrote:

> On 2013/07/12 00:01:28, MarkM wrote:
>
>> Please do remember to include me as a secondary reviewer on CLs which
>>
> include
>
>> ses/* files.
>>
>
> Oops again.
>
> (too bad we don't have a VOC system which makes sure that happens...)
>
>
>
https://codereview.appspot.**com/11180043/<https://codereview.appspot.com/111...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "Google Caja Discuss" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
google-caja-discuss+**unsubscribe@googlegroups.com<google-caja-discuss%2Bunsu...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>


-- 
    Cheers,
    --MarkM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b