Issue 111600044: add genhtml from lcov 1.11 for generating html from drcov2lcov output

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 111600044: add genhtml from lcov 1.11 for generating html from drcov2lcov output (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by zhaoqin

Modified:
11 years, 11 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Base URL:
https://dynamorio.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

add genhtml from lcov 1.11 for generating html from drcov2lcov output R=bruening@google.com BUG=1482 Committed: https://code.google.com/p/dynamorio/source/detail?r=2727

Patch Set 3 : add COPYING #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6331 lines, -0 lines)			Patch
A	third_party/lcov/COPYING	View	1 2	1 chunk	+339 lines, -0 lines	0 comments	Download
A	third_party/lcov/README.dynamorio	View		1 chunk	+3 lines, -0 lines	1 comment	Download
A	third_party/lcov/genhtml	View		1 chunk	+5989 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

zhaoqin

the genhtml is directly copied from lcov-1.11, so you do not have to read all ...

11 years, 11 months ago (2014-07-23 19:06:08 UTC) #2

bruening

I believe you're supposed to include the GPL license file as well

11 years, 11 months ago (2014-07-23 19:25:18 UTC) #3

bruening

LGTM https://codereview.appspot.com/111600044/diff/40001/third_party/lcov/README.dynamorio File third_party/lcov/README.dynamorio (right): https://codereview.appspot.com/111600044/diff/40001/third_party/lcov/README.dynamorio#newcode3 third_party/lcov/README.dynamorio:3: http://ltp.sourceforge.net/coverage/lcov.php I would also state that it's covered ...

11 years, 11 months ago (2014-07-24 16:14:26 UTC) #5

zhaoqin

11 years, 11 months ago (2014-07-24 20:16:20 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r2727 (presubmit successful).

Expand All Messages | Collapse All Messages