Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(602)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 11156043: build: fix make check (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Daiki Ueno
Modified:
12 years, 6 months ago
Reviewers:
shawn.p.huang, fujiwara, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

build: fix make check This contains several fixes to the current tests: - Remove glib mem profiler call from src/tests, which is known not to work with the latest glib release: https://bugzilla.gnome.org/show_bug.cgi?id=701694 valgrind could be used instead. - Replace g_type_init() call in tests with ibus_init(). - Fix ibus-bus test after the DBus property change (commit 458945e7). no global engine may be set in the test environment. Also add more assertions to check the return values. - Fix pygobject test to use LOG_COMPILER and move sys.path adjustment into the test script itself. - Add new files to po/POTFILES.in. BUG= R=takao.fujiwara1@gmail.com Committed: 9037ffe

Patch Set 1 #

Patch Set 2 : more g_type_init() -> ibus_init() #

Total comments: 4

Patch Set 3 : fix indent and tabs #

Patch Set 4 : list ui/gtk2/* in POTFILES.skip instead of POTFILES.in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -107 lines) Patch
M bindings/pygobject/Makefile.am View 1 chunk +2 lines, -1 line 0 comments Download
M bindings/pygobject/gi/__init__.py View 1 chunk +0 lines, -4 lines 0 comments Download
M bindings/pygobject/gi/overrides/__init__.py View 1 chunk +0 lines, -4 lines 0 comments Download
M bindings/pygobject/test-override-ibus.py View 1 chunk +10 lines, -0 lines 0 comments Download
M po/POTFILES.in View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M po/POTFILES.skip View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M src/tests/ibus-bus.c View 1 chunk +11 lines, -2 lines 0 comments Download
M src/tests/ibus-configservice.c View 1 chunk +2 lines, -4 lines 0 comments Download
M src/tests/ibus-engine.c View 1 2 1 chunk +9 lines, -11 lines 0 comments Download
M src/tests/ibus-factory.c View 1 chunk +2 lines, -4 lines 0 comments Download
M src/tests/ibus-global-engine.c View 1 2 1 chunk +39 lines, -42 lines 0 comments Download
M src/tests/ibus-inputcontext.c View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/tests/ibus-inputcontext-create.c View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/tests/ibus-keymap.c View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M src/tests/ibus-keynames.c View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/tests/ibus-proxy.c View 1 2 1 chunk +12 lines, -14 lines 0 comments Download
M src/tests/ibus-registry.c View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/tests/ibus-serializable.c View 1 chunk +2 lines, -4 lines 0 comments Download
M src/tests/ibus-share.c View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8
Daiki Ueno
bus/test-stress is still failing. perhaps it could be an interactive test rather than a unit ...
12 years, 6 months ago (2013-07-11 09:38:38 UTC) #1
Peng
+ Fujiwara as a reviewer https://codereview.appspot.com/11156043/diff/4001/src/tests/ibus-engine.c File src/tests/ibus-engine.c (right): https://codereview.appspot.com/11156043/diff/4001/src/tests/ibus-engine.c#newcode8 src/tests/ibus-engine.c:8: GMainLoop *mainloop; 4 spaces ...
12 years, 6 months ago (2013-07-11 15:54:53 UTC) #2
Peng
On 2013/07/11 15:54:53, Peng wrote: > + Fujiwara as a reviewer > > https://codereview.appspot.com/11156043/diff/4001/src/tests/ibus-engine.c > ...
12 years, 6 months ago (2013-07-11 15:55:25 UTC) #3
Daiki Ueno
https://codereview.appspot.com/11156043/diff/4001/src/tests/ibus-engine.c File src/tests/ibus-engine.c (right): https://codereview.appspot.com/11156043/diff/4001/src/tests/ibus-engine.c#newcode8 src/tests/ibus-engine.c:8: GMainLoop *mainloop; On 2013/07/11 15:54:53, Peng wrote: > 4 ...
12 years, 6 months ago (2013-07-12 04:45:38 UTC) #4
fujiwara
https://codereview.appspot.com/11156043/diff/4001/po/POTFILES.in File po/POTFILES.in (right): https://codereview.appspot.com/11156043/diff/4001/po/POTFILES.in#newcode57 po/POTFILES.in:57: ui/gtk2/panel.py Remove ui/gtk2/* so that make dist does not ...
12 years, 6 months ago (2013-07-12 06:09:28 UTC) #5
Daiki Ueno
https://codereview.appspot.com/11156043/diff/4001/po/POTFILES.in File po/POTFILES.in (right): https://codereview.appspot.com/11156043/diff/4001/po/POTFILES.in#newcode57 po/POTFILES.in:57: ui/gtk2/panel.py On 2013/07/12 06:09:28, fujiwara wrote: > Remove ui/gtk2/* ...
12 years, 6 months ago (2013-07-12 06:49:49 UTC) #6
fujiwara
lgtm.
12 years, 6 months ago (2013-07-12 07:28:57 UTC) #7
Daiki Ueno
12 years, 6 months ago (2013-07-12 09:05:12 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 manually as r9037ffe (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b