Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 11140043: Refactoring in the scanner and removing broken Domado features. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by kpreid2
Modified:
12 years, 8 months ago
Reviewers:
felix8a, ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

These changes are to support upcoming improvements to the scanner. Domado: * Removed HTMLMediaElement.prototype.fastSeek, as no browser implements it yet. * window.pageXOffset and window.pageYOffset no longer have (broken) setters. es53-test-scan-guest.js: * noteGap takes an (optional) context arg like noteProblem. * Factored out specialized whole-object checks from Scanner. * annotate() will compose with an existing annotation rather than overwriting it silently. * freshResult() will not fail if the result is not an object. * Fixed testScanner passing an object instead of a string to scanner.skip(). @r5494

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -46 lines) Patch
M src/com/google/caja/plugin/domado.js View 4 chunks +17 lines, -12 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-scan-guest.js View 15 chunks +62 lines, -34 lines 1 comment Download

Messages

Total messages: 5
kpreid2
12 years, 8 months ago (2013-07-11 00:05:23 UTC) #1
kpreid2
ping
12 years, 8 months ago (2013-07-15 20:47:49 UTC) #2
ihab.awad
Not familiar with architecture of scanner so abandoning effort to review that portion. Domado portion ...
12 years, 8 months ago (2013-07-15 21:51:51 UTC) #3
ihab.awad
To clarify: * Domado portion lgtm; * Scanner portion lgtm as-is since we have not ...
12 years, 8 months ago (2013-07-15 22:35:00 UTC) #4
felix8a
12 years, 8 months ago (2013-07-15 23:22:32 UTC) #5
Message was sent while issue was closed.
I reviewed the initial checkin of the scanner. lgtm

https://codereview.appspot.com/11140043/diff/1/tests/com/google/caja/plugin/e...
File tests/com/google/caja/plugin/es53-test-scan-guest.js (right):

https://codereview.appspot.com/11140043/diff/1/tests/com/google/caja/plugin/e...
tests/com/google/caja/plugin/es53-test-scan-guest.js:1034: var original =
call[2];
putting the var here is odd, it took me a minute to connect it with the function
that used it and figure out the intent.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b