Change private checkbox to protected and add help text

On the edit form, use the label "Protected" instead of "Private".

To accommodate help text, space out all input fields from each other a little more, make the labels closer to the form elements (rather than the middle of the form element table cell).

To emphasize the need to avoid mailing lists on protected issue, show that help text in bold and make it appear whenever the checkbox is checked.

B=394013

[jrobbins (corp), 2014-07-15 18:46:17]

PTAL.

[cmp, 2014-07-15 18:53:27]

lgtm with nit

https://codereview.appspot.com/111210043/diff/1/codereview/views.py
File codereview/views.py (right):

https://codereview.appspot.com/111210043/diff/1/codereview/views.py#newcode258
codereview/views.py:258: 'Only viewable by @chromium and @google accounts.  <div
class="if_checked">'
Nit: limit to 80 chars

[jrobbins (corp), 2014-07-15 18:58:49]

Fixed nit and committed as
https://code.google.com/p/rietveld/source/detail?r=0072644f4ae3e1d4defbba1330...


On Tue, Jul 15, 2014 at 11:53 AM, <cmp@chromium.org> wrote:

> lgtm with nit
>
>
> https://codereview.appspot.com/111210043/diff/1/codereview/views.py
> File codereview/views.py (right):
>
> https://codereview.appspot.com/111210043/diff/1/
> codereview/views.py#newcode258
> codereview/views.py:258: 'Only viewable by @chromium and @google
> accounts.  <div class="if_checked">'
> Nit: limit to 80 chars
>
> https://codereview.appspot.com/111210043/
>

[iannucci, 2014-07-17 18:34:23]

retro-lgtm

[techtonik, 2015-10-18 07:16:41]

This creates issues that people can't find how to make issue private.

https://github.com/rietveld-codereview/rietveld/issues/523