Issue 11117043: apiserver/deployer: Deployer API facade (v1)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11117043: apiserver/deployer: Deployer API facade (v1) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by dimitern

Modified:
10 years, 9 months ago

Reviewers:
mp+173976, fwereade

Visibility:
Public.

Description

apiserver/deployer: Deployer API facade (v1) Initial implementation of the API facade for the deployer worker. Two calls implemented: WatchUnits and Remove (doing EnsureDead and Remove on a list of machines). In a follow-up the client-side will be implemented. https://code.launchpad.net/~dimitern/juju-core/067-apiserver-deployer/+merge/173976 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+242 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/params/internal.go	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	state/apiserver/deployer/deployer.go	View	1 chunk	+85 lines, -0 lines	1 comment	Download
A	state/apiserver/deployer/deployer_test.go	View	1 chunk	+147 lines, -0 lines	0 comments	Download
M	state/apiserver/upgrader/upgrader.go	View	1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

https://codereview.appspot.com/11117043/diff/1/state/apiserver/deployer/deployer.go File state/apiserver/deployer/deployer.go (right): https://codereview.appspot.com/11117043/diff/1/state/apiserver/deployer/deployer.go#newcode41 state/apiserver/deployer/deployer.go:41: if d.authorizer.AuthOwner(entity.Tag) { Sorry, we've had a miscommunication. The ...

10 years, 9 months ago (2013-07-10 15:54:52 UTC) #2

dimitern

10 years, 9 months ago (2013-07-11 09:49:34 UTC) #3

Closing this and I'm going to propose a better solution.

Expand All Messages | Collapse All Messages