Issue 11108043: Live test for new Storage.RemoveAll() method.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11108043: Live test for new Storage.RemoveAll() method. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by jtv.canonical

Modified:
10 years, 8 months ago

Reviewers:
mue, mp+173934, jameinel

Visibility:
Public.

Description

Live test for new Storage.RemoveAll() method. This is a leftover from another review: the environs.Storage interface now has a RemoveAll method, and the live tests should exercise it. https://code.launchpad.net/~jtv/juju-core/livetest-removeall/+merge/173934 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/jujutest/livetests.go	View		1 chunk	+8 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jameinel

LGTM https://codereview.appspot.com/11108043/diff/1/environs/jujutest/livetests.go File environs/jujutest/livetests.go (left): https://codereview.appspot.com/11108043/diff/1/environs/jujutest/livetests.go#oldcode697 environs/jujutest/livetests.go:697: c.Check(err, IsNil) I would usually ask that this ...

10 years, 9 months ago (2013-07-10 13:27:12 UTC) #2

LGTM

Expand All Messages | Collapse All Messages