Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(213)

Issue 111042: Distinguish valueless attribs (checked, selected) in the HTML attribute schemas (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 7 months ago by MikeSamuel
Modified:
16 years, 7 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

HTML allows some valueless attributes. <input checked> is equivalent to <input checked="checked"> The HTML schema table distinguishes these by putting the attribute name as the only allowed value. This change modifies the perl script that derives the JSON doc, and the JSON HTML attributes, and it adds programmatic support via the HTML.Attrib class. It also changes the value criterion used to check untyped HTML attributes values to allow the value criteria to be converted to Javascript regular expressions so that they can be evaluated client side. Submited @3658

Patch Set 1 #

Total comments: 13

Patch Set 2 : Distinguish valueless attribs (checked, selected) in the HTML attribute schemas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -76 lines) Patch
M src/com/google/caja/lang/html/HTML.java View 1 3 chunks +25 lines, -6 lines 0 comments Download
M src/com/google/caja/lang/html/HtmlDefinitions.java View 1 2 chunks +6 lines, -1 line 0 comments Download
M src/com/google/caja/lang/html/HtmlSchema.java View 1 5 chunks +15 lines, -37 lines 0 comments Download
A src/com/google/caja/lang/html/RegularCriterion.java View 1 1 chunk +116 lines, -0 lines 0 comments Download
M src/com/google/caja/lang/html/html4-attributes.json View 2 chunks +8 lines, -1 line 0 comments Download
M src/com/google/caja/lang/html/html4-attributes.pl View 5 chunks +15 lines, -5 lines 0 comments Download
M src/com/google/caja/lang/html/html4-attributes-defs.json View 9 chunks +27 lines, -26 lines 0 comments Download

Messages

Total messages: 4
MikeSamuel
16 years, 7 months ago (2009-08-26 01:47:21 UTC) #1
metaweta
LGTM once these nits are fixed. http://codereview.appspot.com/111042/diff/1/4 File src/com/google/caja/lang/html/HTML.java (right): http://codereview.appspot.com/111042/diff/1/4#newcode186 Line 186: /** Is ...
16 years, 7 months ago (2009-08-26 21:45:41 UTC) #2
MikeSamuel
http://codereview.appspot.com/111042/diff/1/4 File src/com/google/caja/lang/html/HTML.java (right): http://codereview.appspot.com/111042/diff/1/4#newcode186 Line 186: /** Is the attribute required on all elements ...
16 years, 7 months ago (2009-08-26 22:02:19 UTC) #3
metaweta
16 years, 7 months ago (2009-08-26 22:09:37 UTC) #4
http://codereview.appspot.com/111042/diff/1/2
File src/com/google/caja/lang/html/HtmlDefinitions.java (right):

http://codereview.appspot.com/111042/diff/1/2#newcode183
Line 183: A_TYPE_MAP.put(HTML.Attribute.Type.GLOBAL_NAME, 7);
On 2009/08/26 22:02:19, MikeSamuel wrote:
> On 2009/08/26 21:45:41, metaweta wrote:
> > Duplicate entry
> 
> Where?
> 

Weird.  When I was reviewing it, this line appeared twice.  Never mind.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b