Issue 1110041: JSONP and CORS for rest requests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1110041: JSONP and CORS for rest requests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by Paul Lindner

Modified:
15 years, 8 months ago

Reviewers:
johnfargo, shindig.remailer

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java	View		3 chunks	+9 lines, -1 line	3 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

johnfargo

15 years, 8 months ago (2010-05-05 01:44:56 UTC) #2

meta-comment: test?

http://codereview.appspot.com/1110041/diff/1/2
File
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java
(right):

http://codereview.appspot.com/1110041/diff/1/2#newcode100
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:100:
HttpUtil.setCORSheader(servletResponse);
This appears to be new; can't find any reference to it in HttpUtil@head.

http://codereview.appspot.com/1110041/diff/1/2#newcode175
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:175:
String callback =  (HttpUtil.isJSONP(servletRequest) &&
ContentTypes.OUTPUT_JSON_CONTENT_TYPE.equals(converter.getContentType())) ?
nit: reduce this line to 100 char

http://codereview.appspot.com/1110041/diff/1/2#newcode180
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:180:
if (callback != null) writer.write(");\n");
this whole chunk of new code can probably be pulled into an HttpUtil helper no?

Expand All Messages | Collapse All Messages