Issue 11099043: Introduce window_bits constructor parameter to util._Inflate.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11099043: Introduce window_bits constructor parameter to util._Inflate. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Yutaka Hirano

Modified:
13 years ago

Reviewers:
tyoshino (chromium.org)

CC:
pywebsocket-reviews_googlegroups.com

Base URL:
http://pywebsocket.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Introduce window_bits constructor parameter to util._Inflate. This change enables us to delete a dirty hack in a Blink layout test. See http://crbug.com/235822 . R=tyoshino@chromium.org Committed: https://code.google.com/p/pywebsocket/source/detail?r=777

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -5 lines)			Patch
	M	src/mod_pywebsocket/util.py	View	1 2	4 chunks	+6 lines, -5 lines	0 comments	Download
	M	src/test/test_util.py	View	1 2	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

tyoshino (chromium.org)

LGTM https://codereview.appspot.com/11099043/diff/1/src/mod_pywebsocket/util.py File src/mod_pywebsocket/util.py (right): https://codereview.appspot.com/11099043/diff/1/src/mod_pywebsocket/util.py#newcode380 src/mod_pywebsocket/util.py:380: self._inflater = _Inflater() set zlib.MAX_WBITS plz

13 years ago (2013-07-10 08:03:12 UTC) #2

Yutaka Hirano

https://codereview.appspot.com/11099043/diff/1/src/mod_pywebsocket/util.py File src/mod_pywebsocket/util.py (right): https://codereview.appspot.com/11099043/diff/1/src/mod_pywebsocket/util.py#newcode380 src/mod_pywebsocket/util.py:380: self._inflater = _Inflater() On 2013/07/10 08:03:12, tyoshino (Chromium) wrote: ...

13 years ago (2013-07-10 08:10:32 UTC) #3

Yutaka Hirano

13 years ago (2013-07-10 08:19:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r777 (presubmit successful).

Expand All Messages | Collapse All Messages