Issue 1109041: Support Cross-Site Request Sharing in Shindig JSONP

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1109041: Support Cross-Site Request Sharing in Shindig JSONP (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by Paul Lindner

Modified:
15 years, 8 months ago

Reviewers:
johnfargo, shindig.remailer

Visibility:
Public.

Patch Set 2 : Updated CORS Patch with ContainerConfig mods #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -13 lines)			Patch
M	config/container.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/common/servlet/HttpUtil.java	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/config/AbstractContainerConfig.java	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/config/ContainerConfig.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java	View		3 chunks	+12 lines, -0 lines	0 comments	Download
M	java/common/src/main/java/org/apache/shindig/protocol/JsonRpcServlet.java	View	1	5 chunks	+5 lines, -4 lines	0 comments	Download
M	java/common/src/test/java/org/apache/shindig/common/servlet/HttpUtilTest.java	View		2 chunks	+22 lines, -1 line	0 comments	Download
M	java/common/src/test/java/org/apache/shindig/protocol/DataServiceServletTest.java	View		4 chunks	+5 lines, -2 lines	0 comments	Download
M	java/common/src/test/java/org/apache/shindig/protocol/JsonRpcServletTest.java	View		4 chunks	+5 lines, -0 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/RpcServletTest.java	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/AbstractLargeRestfulTests.java	View		3 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Paul Lindner

More info about this here: http://www.w3.org/TR/cors/

15 years, 8 months ago (2010-05-05 01:11:12 UTC) #2

johnfargo

Curious, have you got a list of current browsers that are CORS conformant?

15 years, 8 months ago (2010-05-05 02:05:44 UTC) #3

johnfargo

http://codereview.appspot.com/1109041/diff/1/2 File java/common/src/main/java/org/apache/shindig/common/servlet/HttpUtil.java (right): http://codereview.appspot.com/1109041/diff/1/2#newcode134 java/common/src/main/java/org/apache/shindig/common/servlet/HttpUtil.java:134: resp.addHeader("Access-Control-Allow-Origin", "*"); as a basic security primitive, this should ...

15 years, 8 months ago (2010-05-05 02:10:55 UTC) #4

Expand All Messages | Collapse All Messages