Issue 11052043: Bundle virtualization info used by CSS sanitizer into one object.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 11052043: Bundle virtualization info used by CSS sanitizer into one object. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by kpreid2

Modified:
12 years, 8 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Replace domicile.suffixStr and domicile.tagPolicy with an object domicile.virtualization which contains the same information, and distinguishes the container class name from the ID suffix. This reduces the number of independent values passed around and reduces the number of places that independently compute class from suffix or vice versa. Also removed unused function domicile.ident. @r5481

Patch Set 1 #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -77 lines)			Patch
M	src/com/google/caja/plugin/domado.js	View	6 chunks	+27 lines, -22 lines	0 comments	Download
M	src/com/google/caja/plugin/html-emitter.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/sanitizecss.js	View	9 chunks	+49 lines, -34 lines	0 comments	Download
M	tests/com/google/caja/plugin/css-stylesheet-test.js	View	2 chunks	+21 lines, -16 lines	0 comments	Download
M	tests/com/google/caja/plugin/sanitizecss_test.js	View	3 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages