Memzero the corrupt info buffer before reporting it.

Memzero the corrupt info buffer before reporting it.

One of the side effect of this is that it sets the TIDs of the corrupt blocks to 0 before reporting them.

BUG=
R=siggi@chromium.org

Committed: https://code.google.com/p/sawbuck/source/detail?r=2181

[Sébastien Marchand, 2014-07-08 16:53:58]

PTAL.

[Siggi, 2014-07-08 17:00:02]

I don't think this is the right thing to do. Better to memset() the whole
allocation to zero, and assert on zero fields where we don't populate them.


On Tue, Jul 8, 2014 at 12:53 PM, <sebmarchand@chromium.org> wrote:

> Reviewers: Siggi,
>
> Message:
> PTAL.
>
> Description:
> Set the TIDs of the corrupt blocks to 0 before reporting them.
>
> BUG=
>
> Please review this at https://codereview.appspot.com/110410043/
>
> Affected files (+3, -0 lines):
>   M syzygy/agent/asan/asan_heap.cc
>
>
> Index: syzygy/agent/asan/asan_heap.cc
> diff --git a/syzygy/agent/asan/asan_heap.cc b/syzygy/agent/asan/asan_heap.
> cc
> index 66452f6eb0d647b939f06a153fdcf0ffc92ad7d8..
> 94b9a0a9e52452ef10e1992dd052f66c2f00ccfa 100644
> --- a/syzygy/agent/asan/asan_heap.cc
> +++ b/syzygy/agent/asan/asan_heap.cc
> @@ -1369,6 +1369,9 @@ void HeapProxy::GetBlockInfo(AsanBlockInfo*
> block_info) {
>      BlockTrailer* trailer = BlockHeaderToBlockTrailer(header);
>      block_info->alloc_tid = trailer->alloc_tid;
>      block_info->free_tid = trailer->free_tid;
> +  } else {
> +    block_info->alloc_tid = 0;
> +    block_info->free_tid = 0;
>    }
>
>    block_info->state = header->state;
>
>
>

[Sébastien Marchand, 2014-07-08 17:09:34]

Thanks, here's another approach, PTAnL.

[Siggi, 2014-07-08 17:10:36]

lgtm - thanks!

[Sébastien Marchand, 2014-07-08 17:21:01]

Thanks, committing.

[Sébastien Marchand, 2014-07-08 17:30:51]

Committed patchset #2 manually as r2181 (presubmit successful).