Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(632)

Issue 1103041: code review 1103041: os: add Utime function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by brad_danga_com
Modified:
12 years, 3 months ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

os: add Utime function

Patch Set 1 #

Patch Set 2 : code review 1103041: os: add Utime function #

Total comments: 4

Patch Set 3 : code review 1103041: os: add Utime function #

Patch Set 4 : code review 1103041: os: add Utime function #

Patch Set 5 : code review 1103041: os: add Utime function #

Total comments: 4

Patch Set 6 : code review 1103041: os: add Utime function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M src/pkg/os/file.go View 1 2 3 4 5 1 chunk +16 lines, -0 lines 0 comments Download
M src/pkg/os/os_test.go View 1 2 3 4 5 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 19
brad_danga_com
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
12 years, 5 months ago (2010-05-04 19:40:15 UTC) #1
r
LGTM leaving for rsc http://codereview.appspot.com/1103041/diff/2001/3002 File src/pkg/os/os_test.go (right): http://codereview.appspot.com/1103041/diff/2001/3002#newcode493 src/pkg/os/os_test.go:493: fd.Write([]byte("hello, world\n")) you could use ...
12 years, 5 months ago (2010-05-05 00:56:07 UTC) #2
brad_danga_com
Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 5 months ago (2010-05-05 14:33:26 UTC) #3
brad_danga_com
Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 5 months ago (2010-05-05 14:35:02 UTC) #4
brad_danga_com
PTAL http://codereview.appspot.com/1103041/diff/2001/3002 File src/pkg/os/os_test.go (right): http://codereview.appspot.com/1103041/diff/2001/3002#newcode493 src/pkg/os/os_test.go:493: fd.Write([]byte("hello, world\n")) On 2010/05/05 00:56:07, r wrote: > ...
12 years, 5 months ago (2010-05-05 14:36:34 UTC) #5
rog
i still think that Chtime or Chtimes would be a better name for this call, ...
12 years, 5 months ago (2010-05-05 15:21:05 UTC) #6
dangabrad
I'm happy with whatever, including Chtimes. The win32 argument is good, but I imagine pkg ...
12 years, 5 months ago (2010-05-05 16:34:18 UTC) #7
rsc
On Wed, May 5, 2010 at 08:21, roger peppe <rogpeppe@gmail.com> wrote: > i still think ...
12 years, 5 months ago (2010-05-05 16:34:59 UTC) #8
rog
i guess. FWIW, there are other functions in os that don't correspond directly to their ...
12 years, 5 months ago (2010-05-05 17:09:58 UTC) #9
dangabrad
Arguably, "U" is Update in the same way "Ch" is Change, if you're calling "Ch" ...
12 years, 5 months ago (2010-05-05 17:11:58 UTC) #10
rog
ah, maybe that's the case. my addled brain could only make "user", which naturally made ...
12 years, 5 months ago (2010-05-05 17:32:59 UTC) #11
r2
i can go either way but i must admit i like Chtime[s] better. -rob On ...
12 years, 5 months ago (2010-05-05 17:36:06 UTC) #12
dangabrad
How about I name it Chtimes and mention utime/utimes in the docs for people doing ...
12 years, 5 months ago (2010-05-05 17:38:34 UTC) #13
rsc
Sounds good. On Wed, May 5, 2010 at 10:38, Brad Fitzpatrick <brad@danga.com> wrote: > How ...
12 years, 5 months ago (2010-05-05 17:48:50 UTC) #14
brad_danga_com
Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 5 months ago (2010-05-05 17:50:52 UTC) #15
r
LGTM modulo commentary leaving for rsc http://codereview.appspot.com/1103041/diff/5002/23002 File src/pkg/os/file.go (right): http://codereview.appspot.com/1103041/diff/5002/23002#newcode414 src/pkg/os/file.go:414: // Note that ...
12 years, 5 months ago (2010-05-05 18:02:04 UTC) #16
brad_danga_com
Hello rsc, r (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 5 months ago (2010-05-05 18:22:00 UTC) #17
rsc
LGTM Thanks.
12 years, 5 months ago (2010-05-05 18:27:17 UTC) #18
rsc
12 years, 4 months ago (2010-05-20 00:49:01 UTC) #19
*** Submitted as http://code.google.com/p/go/source/detail?r=a79cd7447eaa ***

os: add Chtimes function

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/1103041

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b