Issue 110102: One more global var in domita.js

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 110102: One more global var in domita.js (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by MikeSamuel

Modified:
16 years, 9 months ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Submitted @3669

Patch Set 1 #

Total comments: 1

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	src/com/google/caja/plugin/domita.js	View		5 chunks	+7 lines, -7 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

metaweta

16 years, 9 months ago (2009-08-27 22:16:49 UTC) #2

LGTM

http://codereview.appspot.com/110102/diff/1/2
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/110102/diff/1/2#newcode2706
Line 2706: var nameLc = String(name).toLowerCase();
I remember what happened: I was originally changing the value of name, not
nameLc, so it was already a local variable.  Sorry.

Expand All Messages | Collapse All Messages