Issue 110098: Issue 1061: experimental/prototype is busted - cannot run Prototype tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 110098: Issue 1061: experimental/prototype is busted - cannot run Prototype tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by MikeSamuel

Modified:
16 years, 9 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

ptwobrussel said at http://code.google.com/p/google-caja/issues/detail?id=1061 The fix is to go into whitelist/html_attrib.json and change : to :: for separators. Apparently, this file didn't get updated when the separator changed in the past? Not sure what the history is on that. Submitted @3683

Patch Set 1 #

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	experimental/prototype/test/lib/caja/whitelist/html_attrib.json	View		1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ihab.awad

16 years, 9 months ago (2009-09-02 04:22:58 UTC) #2

LGTM

But note that experimental/prototype is set to be retired -- it is superseded by
Tobie Langel's branch on Github.

Expand All Messages | Collapse All Messages