Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 110049: Tryton download script in python (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by yangoon1
Modified:
11 years ago
Reviewers:
yangoon1, h.goebel, ced1
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Don't try to download duplicate module names\nClean up white space #

Patch Set 3 : Forgotten comments #

Total comments: 1

Patch Set 4 : Use set instead of list #

Total comments: 2

Patch Set 5 : Using different regex instead of set #

Patch Set 6 : Patch by htgoebel: Changed baseurl for seaching the modules. #

Patch Set 7 : Removing spaces on empty line from previous patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -0 lines) Patch
A tryton-dev View 1 2 3 4 5 6 1 chunk +160 lines, -0 lines 0 comments Download

Messages

Total messages: 9
ced1
http://codereview.appspot.com/110049/diff/7/8 File tryton-dev (right): http://codereview.appspot.com/110049/diff/7/8#newcode124 Line 124: modules.append(module) You can use a set instead of ...
11 years, 2 months ago (2009-08-20 13:44:06 UTC) #1
h.goebel
http://codereview.appspot.com/110049/diff/1003/1004 File tryton-dev (right): http://codereview.appspot.com/110049/diff/1003/1004#newcode122 Line 122: if module in modules: Why should there be ...
11 years, 2 months ago (2009-08-22 14:17:39 UTC) #2
yangoon1
http://codereview.appspot.com/110049/diff/1003/1004 File tryton-dev (right): http://codereview.appspot.com/110049/diff/1003/1004#newcode122 Line 122: if module in modules: On 2009/08/22 14:17:39, h.goebel ...
11 years, 2 months ago (2009-08-22 22:11:33 UTC) #3
h.goebel
On 2009/08/22 22:11:33, yangoon wrote: > The regular expression just finds all modules, in all ...
11 years, 2 months ago (2009-08-25 13:54:06 UTC) #4
yangoon1
11 years, 1 month ago (2009-09-06 13:28:06 UTC) #5
yangoon1
11 years ago (2009-10-06 17:48:41 UTC) #6
yangoon1
11 years ago (2009-10-06 17:50:44 UTC) #7
h.goebel
I've tested the latest patches for both with and without branch and it works as ...
11 years ago (2009-10-07 07:35:31 UTC) #8
yangoon1
11 years ago (2009-10-07 09:54:40 UTC) #9
On 2009/10/07 07:35:31, h.goebel wrote:
> I've tested the latest patches for both with and without branch and it works
as
> expected. I suggest pushing the current version to roundup and replace old
> tryton-dev.sh

I have tested this script, too, and it works ok now and provides extended
functionality.

Nevertheless I would propose a different name like tryton-download.

I don' t recommend to replace the old script tryton-dev.sh, but to put it as
alternative in the repos. This way manuals can refer to the one or the other and
don't need to be fixed.

h.goebel: would you please provide the patch against repos tryton-dev and put it
on https://bugs.tryton.org/roundup/issue1132?

Thx
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b