Fix building with Clang 3.2 (brute force approach)

Fix building with Clang 3.2 (brute force approach)

[Andrey Mazo, 2013-10-14 13:27:11]

Most of the changes look good to me.

https://codereview.appspot.com/10975043/diff/8001/src/buildings/helper/buildi...
File src/buildings/helper/building-position-allocator.cc (right):

https://codereview.appspot.com/10975043/diff/8001/src/buildings/helper/buildi...
src/buildings/helper/building-position-allocator.cc:32: #include "ns3/unused.h"
I suppose, this change can be safely dropped.

https://codereview.appspot.com/10975043/diff/8001/src/core/test/attribute-tes...
File src/core/test/attribute-test-suite.cc (right):

https://codereview.appspot.com/10975043/diff/8001/src/core/test/attribute-tes...
src/core/test/attribute-test-suite.cc:226: }
Peter D. Barnes has recently added NS_UNUSED_GLOBAL() macro.
I suppose, it's possible to mark class members as unused directly in the class
declaration without use of extra function.

Something like
class AttributeObjectTest
{
private:
...
bool NS_UNUSED_GLOBAL (m_boolTest);
...
}

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-fdbet...
File src/lte/test/lte-test-fdbet-ff-mac-scheduler.cc (right):

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-fdbet...
src/lte/test/lte-test-fdbet-ff-mac-scheduler.cc:194: NS_UNUSED (m_nLc);
Is it possible to just remove the m_nLc field together with nLc constructor
argument?

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-fdtbf...
File src/lte/test/lte-test-fdtbfq-ff-mac-scheduler.cc (right):

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-fdtbf...
src/lte/test/lte-test-fdtbfq-ff-mac-scheduler.cc:251: NS_UNUSED (m_nLc);
The same question as for lte-test-fdbet-ff-mac-scheduler.cc.

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-harq.cc
File src/lte/test/lte-test-harq.cc (right):

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-harq....
src/lte/test/lte-test-harq.cc:100: NS_UNUSED (m_tbSize);
The same question as for lte-test-fdbet-ff-mac-scheduler.cc.

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-inter...
File src/lte/test/lte-test-interference.cc (right):

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-inter...
src/lte/test/lte-test-interference.cc:107: NS_UNUSED (m_ulSe);
The same question as for lte-test-fdbet-ff-mac-scheduler.cc.

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-phy-e...
File src/lte/test/lte-test-phy-error-model.cc (right):

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-phy-e...
src/lte/test/lte-test-phy-error-model.cc:120: NS_UNUSED (m_tbSize);
The same question as for lte-test-fdbet-ff-mac-scheduler.cc.

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-pss-f...
File src/lte/test/lte-test-pss-ff-mac-scheduler.cc (right):

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-pss-f...
src/lte/test/lte-test-pss-ff-mac-scheduler.cc:252: NS_UNUSED (m_nLc);
The same question as for lte-test-fdbet-ff-mac-scheduler.cc.

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-tdbet...
File src/lte/test/lte-test-tdbet-ff-mac-scheduler.cc (right):

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-tdbet...
src/lte/test/lte-test-tdbet-ff-mac-scheduler.cc:194: NS_UNUSED (m_nLc);
The same question as for lte-test-fdbet-ff-mac-scheduler.cc.

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-tdtbf...
File src/lte/test/lte-test-tdtbfq-ff-mac-scheduler.cc (right):

https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-tdtbf...
src/lte/test/lte-test-tdtbfq-ff-mac-scheduler.cc:251: NS_UNUSED (m_nLc);
The same question as for lte-test-fdbet-ff-mac-scheduler.cc.

[Tommaso Pecorella, 2013-10-14 14:37:24]

Another error from gcc 5.0


In file included from ../src/mpi/model/distributed-simulator-impl.cc:19:
../src/mpi/model/distributed-simulator-impl.h:149:16: error: private field
'm_systemCount' is not used [-Werror,-Wunused-private-field]
  uint32_t     m_systemCount; // MPI Size

Suggested fix:

DistributedSimulatorImpl::DistributedSimulatorImpl ()
{
#ifdef NS3_MPI
  m_myId = MpiInterface::GetSystemId ();
  m_systemCount = MpiInterface::GetSize ();

  // Allocate the LBTS message buffer
  m_pLBTS = new LbtsMessage[m_systemCount];
  m_grantedTime = Seconds (0);
#else
  NS_UNUSED (m_systemCount);
  NS_FATAL_ERROR ("Can't use distributed simulator without MPI compiled in");
#endif

Other than that, gcc 5.0 is happy with the patch.

[Vedran Miletić, 2013-10-20 10:20:30]

On 2013/10/14 14:37:24, Tommaso Pecorella wrote:
> Another error from gcc 5.0
> 
> 
> In file included from ../src/mpi/model/distributed-simulator-impl.cc:19:
> ../src/mpi/model/distributed-simulator-impl.h:149:16: error: private field
> 'm_systemCount' is not used [-Werror,-Wunused-private-field]
>   uint32_t     m_systemCount; // MPI Size
> 
> Suggested fix:
> 
> DistributedSimulatorImpl::DistributedSimulatorImpl ()
> {
> #ifdef NS3_MPI
>   m_myId = MpiInterface::GetSystemId ();
>   m_systemCount = MpiInterface::GetSize ();
> 
>   // Allocate the LBTS message buffer
>   m_pLBTS = new LbtsMessage[m_systemCount];
>   m_grantedTime = Seconds (0);
> #else
>   NS_UNUSED (m_systemCount);
>   NS_FATAL_ERROR ("Can't use distributed simulator without MPI compiled in");
> #endif
> 
> Other than that, gcc 5.0 is happy with the patch.

Done, thanks for the suggestion.

[Vedran Miletić, 2013-10-20 10:24:58]

On 2013/10/14 13:27:11, Andrey Mazo wrote:
> Most of the changes look good to me.
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/buildings/helper/buildi...
> File src/buildings/helper/building-position-allocator.cc (right):
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/buildings/helper/buildi...
> src/buildings/helper/building-position-allocator.cc:32: #include
"ns3/unused.h"
> I suppose, this change can be safely dropped.

Good catch on that one, not sure why I added this. Perhaps it was fixed by
someone else in the meantime.

>
https://codereview.appspot.com/10975043/diff/8001/src/core/test/attribute-tes...
> File src/core/test/attribute-test-suite.cc (right):
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/core/test/attribute-tes...
> src/core/test/attribute-test-suite.cc:226: }
> Peter D. Barnes has recently added NS_UNUSED_GLOBAL() macro.
> I suppose, it's possible to mark class members as unused directly in the class
> declaration without use of extra function.
> 
> Something like
> class AttributeObjectTest
> {
> private:
> ...
> bool NS_UNUSED_GLOBAL (m_boolTest);
> ...
> }

Done, thanks for the suggestion, much cleaner this way.

>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-fdbet...
> File src/lte/test/lte-test-fdbet-ff-mac-scheduler.cc (right):
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-fdbet...
> src/lte/test/lte-test-fdbet-ff-mac-scheduler.cc:194: NS_UNUSED (m_nLc);
> Is it possible to just remove the m_nLc field together with nLc constructor
> argument?
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-fdtbf...
> File src/lte/test/lte-test-fdtbfq-ff-mac-scheduler.cc (right):
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-fdtbf...
> src/lte/test/lte-test-fdtbfq-ff-mac-scheduler.cc:251: NS_UNUSED (m_nLc);
> The same question as for lte-test-fdbet-ff-mac-scheduler.cc.
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-harq.cc
> File src/lte/test/lte-test-harq.cc (right):
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-harq....
> src/lte/test/lte-test-harq.cc:100: NS_UNUSED (m_tbSize);
> The same question as for lte-test-fdbet-ff-mac-scheduler.cc.
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-inter...
> File src/lte/test/lte-test-interference.cc (right):
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-inter...
> src/lte/test/lte-test-interference.cc:107: NS_UNUSED (m_ulSe);
> The same question as for lte-test-fdbet-ff-mac-scheduler.cc.
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-phy-e...
> File src/lte/test/lte-test-phy-error-model.cc (right):
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-phy-e...
> src/lte/test/lte-test-phy-error-model.cc:120: NS_UNUSED (m_tbSize);
> The same question as for lte-test-fdbet-ff-mac-scheduler.cc.
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-pss-f...
> File src/lte/test/lte-test-pss-ff-mac-scheduler.cc (right):
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-pss-f...
> src/lte/test/lte-test-pss-ff-mac-scheduler.cc:252: NS_UNUSED (m_nLc);
> The same question as for lte-test-fdbet-ff-mac-scheduler.cc.
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-tdbet...
> File src/lte/test/lte-test-tdbet-ff-mac-scheduler.cc (right):
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-tdbet...
> src/lte/test/lte-test-tdbet-ff-mac-scheduler.cc:194: NS_UNUSED (m_nLc);
> The same question as for lte-test-fdbet-ff-mac-scheduler.cc.
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-tdtbf...
> File src/lte/test/lte-test-tdtbfq-ff-mac-scheduler.cc (right):
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-tdtbf...
> src/lte/test/lte-test-tdtbfq-ff-mac-scheduler.cc:251: NS_UNUSED (m_nLc);
> The same question as for lte-test-fdbet-ff-mac-scheduler.cc.

Perhaps it's a future feature of some kind; I can't judge since I'm not LTE
maintainter. I will notify Nicola Baldo about these; I would prefer him to
handle the removal of m_nLc since values used for it vary.

[Andrey Mazo, 2013-10-21 18:42:05]

On 2013/10/20 10:24:58, Vedran Miletić wrote:
>
https://codereview.appspot.com/10975043/diff/8001/src/buildings/helper/buildi...
> > src/buildings/helper/building-position-allocator.cc:32: #include
> "ns3/unused.h"
> > I suppose, this change can be safely dropped.
> 
> Good catch on that one, not sure why I added this. Perhaps it was fixed by
> someone else in the meantime.
> 
>
https://codereview.appspot.com/10975043/diff/8001/src/core/test/attribute-tes...
> > src/core/test/attribute-test-suite.cc:226: }
> > Peter D. Barnes has recently added NS_UNUSED_GLOBAL() macro.
> > I suppose, it's possible to mark class members as unused directly in the
class
> > declaration without use of extra function.
> > 
> > Something like
> > class AttributeObjectTest
> > {
> > private:
> > ...
> > bool NS_UNUSED_GLOBAL (m_boolTest);
> > ...
> > }
> 
> Done, thanks for the suggestion, much cleaner this way.

Thank you for taking my suggestions into account!

>
https://codereview.appspot.com/10975043/diff/8001/src/lte/test/lte-test-tdtbf...
> > src/lte/test/lte-test-tdtbfq-ff-mac-scheduler.cc:251: NS_UNUSED (m_nLc);
> > The same question as for lte-test-fdbet-ff-mac-scheduler.cc.
> 
> Perhaps it's a future feature of some kind; I can't judge since I'm not LTE
> maintainter. I will notify Nicola Baldo about these; I would prefer him to
> handle the removal of m_nLc since values used for it vary.
Notifying Nicola is a good idea, I agree to let him do the appropriate action.