Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(761)

Issue 10974043: data collection for ns-3.18

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by Tom Henderson
Modified:
10 years, 7 months ago
Reviewers:
Vedran Miletić
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This is a revision of a previous code review issue. More information, including a link to the proposed new manual chapter documentation, is available here: https://www.nsnam.org/wiki/index.php/Data_Collection_Framework#July_2013_code_review Still to do: - test suite coverage of aggregators, helpers, probes - write tutorial text to cover the new seventh.cc example - CHANGES.html and RELEASE_NOTES

Patch Set 1 #

Patch Set 2 : updates to remove Collector from patchset #

Total comments: 30

Patch Set 3 : updates based on Vedran's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9146 lines, -290 lines) Patch
M .hgignore View 2 chunks +6 lines, -0 lines 0 comments Download
M doc/manual/Makefile View 1 2 chunks +35 lines, -0 lines 0 comments Download
M doc/manual/source/conf.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M doc/manual/source/index.rst View 1 chunk +2 lines, -0 lines 0 comments Download
M doc/models/Makefile View 2 chunks +0 lines, -3 lines 0 comments Download
M doc/tutorial-pt-br/source/conf.py View 2 chunks +3 lines, -3 lines 0 comments Download
M doc/tutorial/source/conf.py View 1 chunk +3 lines, -3 lines 0 comments Download
A examples/tutorial/seventh.cc View 1 1 chunk +268 lines, -0 lines 0 comments Download
M examples/tutorial/wscript View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/aodv/model/aodv-routing-protocol.h View 3 chunks +17 lines, -0 lines 0 comments Download
M src/aodv/model/aodv-routing-protocol.cc View 13 chunks +33 lines, -12 lines 0 comments Download
M src/aodv/model/aodv-rtable.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/aodv/model/aodv-rtable.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A src/applications/model/application-packet-probe.h View 1 chunk +120 lines, -0 lines 0 comments Download
A src/applications/model/application-packet-probe.cc View 1 chunk +119 lines, -0 lines 0 comments Download
M src/applications/wscript View 2 chunks +2 lines, -0 lines 0 comments Download
M src/dsr/model/dsr-options.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/dsr/model/dsr-routing.h View 2 chunks +4 lines, -5 lines 0 comments Download
A src/internet/model/ipv4-packet-probe.h View 1 chunk +124 lines, -0 lines 0 comments Download
A src/internet/model/ipv4-packet-probe.cc View 1 chunk +123 lines, -0 lines 0 comments Download
M src/internet/wscript View 3 chunks +3 lines, -1 line 0 comments Download
A src/network/utils/packet-data-calculators.h View 1 chunk +76 lines, -0 lines 0 comments Download
A src/network/utils/packet-data-calculators.cc View 1 chunk +118 lines, -0 lines 0 comments Download
A src/network/utils/packet-probe.h View 1 chunk +112 lines, -0 lines 0 comments Download
A src/network/utils/packet-probe.cc View 1 chunk +117 lines, -0 lines 0 comments Download
M src/network/wscript View 3 chunks +5 lines, -1 line 0 comments Download
A src/stats/doc/adaptor.rst View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A src/stats/doc/aggregator.rst View 1 2 1 chunk +398 lines, -0 lines 0 comments Download
A src/stats/doc/collector.rst View 1 1 chunk +18 lines, -0 lines 0 comments Download
A src/stats/doc/data-collection.rst View 1 1 chunk +36 lines, -0 lines 0 comments Download
A src/stats/doc/data-collection-helpers.rst View 1 2 1 chunk +630 lines, -0 lines 0 comments Download
A src/stats/doc/data-collection-overview.rst View 1 chunk +65 lines, -0 lines 0 comments Download
A src/stats/doc/dcf-overview.dia View Binary file 0 comments Download
A src/stats/doc/dcf-overview-with-aggregation.dia View Binary file 0 comments Download
A src/stats/doc/probe.rst View 1 2 1 chunk +468 lines, -0 lines 0 comments Download
A src/stats/doc/scope-and-limitations.rst View 1 1 chunk +50 lines, -0 lines 0 comments Download
A src/stats/examples/double-probe-example.cc View 1 chunk +197 lines, -0 lines 0 comments Download
A src/stats/examples/file-aggregator-example.cc View 1 2 1 chunk +173 lines, -0 lines 0 comments Download
A src/stats/examples/file-helper-example.cc View 1 chunk +157 lines, -0 lines 0 comments Download
A src/stats/examples/gnuplot-aggregator-example.cc View 1 2 1 chunk +91 lines, -0 lines 0 comments Download
M src/stats/examples/gnuplot-example.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A src/stats/examples/gnuplot-helper-example.cc View 1 chunk +160 lines, -0 lines 0 comments Download
M src/stats/examples/wscript View 1 1 chunk +16 lines, -1 line 0 comments Download
A src/stats/helper/file-helper.h View 1 2 1 chunk +309 lines, -0 lines 0 comments Download
A src/stats/helper/file-helper.cc View 1 2 1 chunk +506 lines, -0 lines 0 comments Download
A src/stats/helper/gnuplot-helper.h View 1 2 1 chunk +211 lines, -0 lines 0 comments Download
A src/stats/helper/gnuplot-helper.cc View 1 2 1 chunk +413 lines, -0 lines 0 comments Download
A src/stats/model/boolean-probe.h View 1 1 chunk +103 lines, -0 lines 0 comments Download
A src/stats/model/boolean-probe.cc View 1 1 chunk +108 lines, -0 lines 0 comments Download
A src/stats/model/data-collection-object.h View 1 chunk +67 lines, -0 lines 0 comments Download
A src/stats/model/data-collection-object.cc View 1 chunk +96 lines, -0 lines 0 comments Download
A src/stats/model/double-probe.h View 1 chunk +103 lines, -0 lines 0 comments Download
A src/stats/model/double-probe.cc View 1 chunk +108 lines, -0 lines 0 comments Download
A src/stats/model/file-aggregator.h View 1 chunk +384 lines, -0 lines 0 comments Download
A src/stats/model/file-aggregator.cc View 1 chunk +661 lines, -0 lines 0 comments Download
A src/stats/model/get-wildcard-matches.h View 1 chunk +44 lines, -0 lines 0 comments Download
A src/stats/model/get-wildcard-matches.cc View 1 chunk +148 lines, -0 lines 0 comments Download
M src/stats/model/gnuplot.h View 4 chunks +55 lines, -4 lines 0 comments Download
M src/stats/model/gnuplot.cc View 16 chunks +191 lines, -46 lines 0 comments Download
A src/stats/model/gnuplot-aggregator.h View 1 chunk +296 lines, -0 lines 0 comments Download
A src/stats/model/gnuplot-aggregator.cc View 1 chunk +327 lines, -0 lines 0 comments Download
R src/stats/model/packet-data-calculators.h View 1 chunk +0 lines, -76 lines 0 comments Download
R src/stats/model/packet-data-calculators.cc View 1 chunk +0 lines, -118 lines 0 comments Download
A src/stats/model/probe.h View 1 chunk +79 lines, -0 lines 0 comments Download
A src/stats/model/probe.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A src/stats/model/time-series-adaptor.h View 1 2 1 chunk +115 lines, -0 lines 0 comments Download
A src/stats/model/time-series-adaptor.cc View 1 1 chunk +112 lines, -0 lines 0 comments Download
A src/stats/model/uinteger-16-probe.h View 1 chunk +101 lines, -0 lines 0 comments Download
A src/stats/model/uinteger-16-probe.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A src/stats/model/uinteger-32-probe.h View 1 chunk +101 lines, -0 lines 0 comments Download
A src/stats/model/uinteger-32-probe.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A src/stats/model/uinteger-8-probe.h View 1 chunk +101 lines, -0 lines 0 comments Download
A src/stats/model/uinteger-8-probe.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A src/stats/test/double-probe-test-suite.cc View 1 chunk +165 lines, -0 lines 0 comments Download
M src/stats/wscript View 1 2 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 5
Vedran Miletić
Some comments. Hope this gets pushed for 3.18. Regards, Vedran https://codereview.appspot.com/10974043/diff/3001/.hgignore File .hgignore (right): https://codereview.appspot.com/10974043/diff/3001/.hgignore#newcode44 ...
10 years, 8 months ago (2013-07-30 19:15:32 UTC) #1
Tom Henderson
thanks for you review; I will handle all the comments except the last one that ...
10 years, 8 months ago (2013-07-30 21:16:29 UTC) #2
Tom Henderson
https://codereview.appspot.com/10974043/diff/3001/src/network/utils/packet-data-calculators.h File src/network/utils/packet-data-calculators.h (right): https://codereview.appspot.com/10974043/diff/3001/src/network/utils/packet-data-calculators.h#newcode40 src/network/utils/packet-data-calculators.h:40: void PacketUpdate (std::string path, Ptr<const Packet> packet); On 2013/07/30 ...
10 years, 8 months ago (2013-07-30 21:31:34 UTC) #3
Vedran Miletić
On 2013/07/30 21:16:29, Tom Henderson wrote: > https://codereview.appspot.com/10974043/diff/3001/src/stats/model/time-series-adaptor.cc > File src/stats/model/time-series-adaptor.cc (right): > > https://codereview.appspot.com/10974043/diff/3001/src/stats/model/time-series-adaptor.cc#newcode72 ...
10 years, 8 months ago (2013-07-31 11:35:26 UTC) #4
Tom Henderson
10 years, 7 months ago (2013-08-05 04:18:48 UTC) #5
On 2013/07/31 11:35:26, Vedran Miletić wrote:
> On 2013/07/30 21:16:29, Tom Henderson wrote:
> >
>
https://codereview.appspot.com/10974043/diff/3001/src/stats/model/time-series...
> > File src/stats/model/time-series-adaptor.cc (right):
> > 
> >
>
https://codereview.appspot.com/10974043/diff/3001/src/stats/model/time-series...
> > src/stats/model/time-series-adaptor.cc:72: m_output (Simulator::Now
> > ().GetSeconds (), newData);
> > On 2013/07/30 19:15:32, Vedran Miletić wrote:
> > > I assume this will be generalized?
> > 
> > do not know what you mean
> 
> Documentation mentions configurable time resolution, so the question is along
> the lines "will this be generalized eventually to allow configuring other time
> resolution than seconds"?

Yes, I forgot that we hadn't completed that aspect-- I fixed the documentation
to say that it is not quite done yet.



> 
> Regards,
> Vedran
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b