Issue 10971043: Ngram'ed search, highlights, suggestion on common words

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10971043: Ngram'ed search, highlights, suggestion on common words

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by sharky93

Modified:
11 years, 6 months ago

Reviewers:
TheSheep

Visibility:
Public.

More Reviews

Description

Ngram'ed search, highlights, suggestion on common words

Patch Set 1 : #

Total comments: 5

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -4 lines)			Patch
M	MoinMoin/apps/frontend/views.py	View	4 chunks	+15 lines, -2 lines	3 comments	Download
M	MoinMoin/constants/keys.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	MoinMoin/storage/middleware/indexing.py	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	MoinMoin/templates/search.html	View	2 chunks	+7 lines, -1 line	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

TheSheep

https://codereview.appspot.com/10971043/diff/7001/MoinMoin/apps/frontend/views.py File MoinMoin/apps/frontend/views.py (right): https://codereview.appspot.com/10971043/diff/7001/MoinMoin/apps/frontend/views.py#newcode270 MoinMoin/apps/frontend/views.py:270: omitted.append(text) omitted_words = [token.text for token in analyzer(query, removestops=False) ...

11 years, 6 months ago (2013-07-08 13:39:09 UTC) #1

sharky93

11 years, 6 months ago (2013-07-08 14:18:29 UTC) #2

Replies

https://codereview.appspot.com/10971043/diff/7001/MoinMoin/apps/frontend/view...
File MoinMoin/apps/frontend/views.py (right):

https://codereview.appspot.com/10971043/diff/7001/MoinMoin/apps/frontend/view...
MoinMoin/apps/frontend/views.py:322: omitted=u', '.join(omitted),
hmm, can be done. i missed that jinja supports that in the template itself.
Should i change for the above lines too ?

On 2013/07/08 13:39:09, TheSheep wrote:
> better join them in the template?

https://codereview.appspot.com/10971043/diff/7001/MoinMoin/templates/search.html
File MoinMoin/templates/search.html (right):

https://codereview.appspot.com/10971043/diff/7001/MoinMoin/templates/search.h...
MoinMoin/templates/search.html:71: <p class="info foundtext">{{
result.highlights('contentngram', result['content'])|safe }}</p>
The second argument is the text which is used for highlighting, we can pass
anything there, but something has to be passed. its the 'content' here.

On 2013/07/08 13:39:09, TheSheep wrote:
> why pass the object to its own method?

Expand All Messages | Collapse All Messages