ticket:10944: Delete InputStream code that now no longer is used.

ticket:10944: Delete InputStream code that now no longer is used.

R=markus.icu@gmail.com

Committed: http://bugs.icu-project.org/trac/changeset/36043

[markus.icu, 2014-07-11 20:20:06]

https://codereview.appspot.com/109640044/diff/40001/main/classes/core/src/com...
File main/classes/core/src/com/ibm/icu/impl/ICUBinary.java (right):

https://codereview.appspot.com/109640044/diff/40001/main/classes/core/src/com...
main/classes/core/src/com/ibm/icu/impl/ICUBinary.java:37: * Same as
readHeader(), but returns a VersionInfo rather than a byte[].
rather than a compact int.

[roubert (google), 2014-07-14 15:06:19]

https://codereview.appspot.com/109640044/diff/40001/main/classes/core/src/com...
File main/classes/core/src/com/ibm/icu/impl/ICUBinary.java (right):

https://codereview.appspot.com/109640044/diff/40001/main/classes/core/src/com...
main/classes/core/src/com/ibm/icu/impl/ICUBinary.java:37: * Same as
readHeader(), but returns a VersionInfo rather than a byte[].
On 2014/07/11 20:20:06, markus.icu wrote:
> rather than a compact int.

Done.

[markus.icu, 2014-07-15 19:26:40]

https://codereview.appspot.com/109640044/diff/150001/main/classes/core/src/co...
File main/classes/core/src/com/ibm/icu/impl/ICUBinary.java (right):

https://codereview.appspot.com/109640044/diff/150001/main/classes/core/src/co...
main/classes/core/src/com/ibm/icu/impl/ICUBinary.java:155: (byte)((version >>
16) & 0xff),
no need for the &0xff since you cast to byte (I think I wrote this in another
review already)

https://codereview.appspot.com/109640044/diff/150001/main/classes/core/src/co...
File main/classes/core/src/com/ibm/icu/impl/Trie2.java (right):

https://codereview.appspot.com/109640044/diff/150001/main/classes/core/src/co...
main/classes/core/src/com/ibm/icu/impl/Trie2.java:36: *
Please add roughly here:
    Reads from the current position and leaves the buffer after the end of the
trie.

[roubert (google), 2014-07-15 19:38:25]

https://codereview.appspot.com/109640044/diff/150001/main/classes/core/src/co...
File main/classes/core/src/com/ibm/icu/impl/ICUBinary.java (right):

https://codereview.appspot.com/109640044/diff/150001/main/classes/core/src/co...
main/classes/core/src/com/ibm/icu/impl/ICUBinary.java:155: (byte)((version >>
16) & 0xff),
On 2014/07/15 19:26:40, markus.icu wrote:
> no need for the &0xff since you cast to byte (I think I wrote this in another
> review already)

Yes, you wrote that already, and I've changed that. These lines aren't touched
at all by the changes in this issue 109640044.

https://codereview.appspot.com/109640044/diff/150001/main/classes/core/src/co...
File main/classes/core/src/com/ibm/icu/impl/Trie2.java (right):

https://codereview.appspot.com/109640044/diff/150001/main/classes/core/src/co...
main/classes/core/src/com/ibm/icu/impl/Trie2.java:36: *
On 2014/07/15 19:26:40, markus.icu wrote:
> Please add roughly here:
>     Reads from the current position and leaves the buffer after the end of the
> trie.

Done.

[markus.icu, 2014-07-15 19:52:17]

LGTM

[roubert (google), 2014-07-15 21:28:37]

Committed patchset #10 manually as r36043 (presubmit successful).