Added test for +tickets view

Added test for +tickets view

[dimazest, 2014-07-02 07:38:55]

there are more things to come

https://codereview.appspot.com/109400043/diff/1/_ui_tests/test_tickets.py
File _ui_tests/test_tickets.py (right):

https://codereview.appspot.com/109400043/diff/1/_ui_tests/test_tickets.py#new...
_ui_tests/test_tickets.py:3: 
import pytest

@pytest.yield_fixture
def driver():
    """A driver for a web browser."""
    driver = webdriver.Firefox()

    yield driver

    driver.quit()

Read http://pytest.org/latest/yieldfixture.html

In general we define a resource called driver, which later we can demand it
tests.

https://codereview.appspot.com/109400043/diff/1/_ui_tests/test_tickets.py#new...
_ui_tests/test_tickets.py:9: self.driver = webdriver.Firefox()
you don't need this, because the driver is a fixture

https://codereview.appspot.com/109400043/diff/1/_ui_tests/test_tickets.py#new...
_ui_tests/test_tickets.py:12: def create_ticket(self, itemname, summary, tags):
def create_ticket(..., driver):

Here you request the driver.

https://codereview.appspot.com/109400043/diff/1/_ui_tests/test_tickets.py#new...
_ui_tests/test_tickets.py:16: driver.get(self.base_url + '/+modify/' + itemname
+ '?itemtype=ticket')
use url_for()

btw, base_url can be a fixture that returns a string:

@pytest.fixture
def base_url():
    return 'http://localhost:8080'

https://codereview.appspot.com/109400043/diff/1/_ui_tests/test_tickets.py#new...
_ui_tests/test_tickets.py:19: try:
It worth creating a ticket using moin api. You can test creation of a ticket
using UI in another test.

This test should looks like this:

Given there are closed tickets
When I go to the ticket page
And click the 'show closed' button
Then I see only the closed thickets

https://codereview.appspot.com/109400043/diff/1/_ui_tests/test_tickets.py#new...
_ui_tests/test_tickets.py:21: except:
except in general is a very bad idea.

There should be no uncertainty in a test!

https://codereview.appspot.com/109400043/diff/1/_ui_tests/test_tickets.py#new...
_ui_tests/test_tickets.py:28: driver.get(self.base_url + '/+tickets')
again, use url_for

https://codereview.appspot.com/109400043/diff/1/_ui_tests/test_tickets.py#new...
_ui_tests/test_tickets.py:30: buttons[2].click()
why is it a third button? you can add an id to this button, so you can easily
locate it.

https://codereview.appspot.com/109400043/diff/1/_ui_tests/test_tickets.py#new...
_ui_tests/test_tickets.py:33: if tds:
hmmm, "if" also a bit strange here.

What if you give ticket tds id's fo the tickets: "ticket_{ited_id}" (or
ticket_{item_fname}.

you can query whoosh for all closed tickets and then assert that only these are
shown.

https://codereview.appspot.com/109400043/diff/1/_ui_tests/test_tickets.py#new...
_ui_tests/test_tickets.py:37: def teardown_class(self):
remove, this is in the fixture

[dimazest, 2014-07-02 13:45:08]

https://codereview.appspot.com/109400043/diff/20003/_ui_tests/test_tickets.py
File _ui_tests/test_tickets.py (right):

https://codereview.appspot.com/109400043/diff/20003/_ui_tests/test_tickets.py...
_ui_tests/test_tickets.py:12: 
these empty lines look ugly, maybe it worth getting rid of them

[dimazest, 2014-07-03 08:48:09]

https://codereview.appspot.com/109400043/diff/20003/_ui_tests/test_tickets.py
File _ui_tests/test_tickets.py (right):

https://codereview.appspot.com/109400043/diff/20003/_ui_tests/test_tickets.py...
_ui_tests/test_tickets.py:8: @pytest.yield_fixture
@pytest.fixture

https://codereview.appspot.com/109400043/diff/20003/_ui_tests/test_tickets.py...
_ui_tests/test_tickets.py:9: def driver():
def driver(request):

https://codereview.appspot.com/109400043/diff/20003/_ui_tests/test_tickets.py...
_ui_tests/test_tickets.py:12: 
request.addfinalizer(driver.quit)

https://codereview.appspot.com/109400043/diff/20003/_ui_tests/test_tickets.py...
_ui_tests/test_tickets.py:13: yield driver
remove

https://codereview.appspot.com/109400043/diff/20003/_ui_tests/test_tickets.py...
_ui_tests/test_tickets.py:15: driver.quit()
replace with

return driver

[dimazest, 2014-07-03 12:39:59]

https://codereview.appspot.com/109400043/diff/80001/_ui_tests/test_tickets.py
File _ui_tests/test_tickets.py (right):

https://codereview.appspot.com/109400043/diff/80001/_ui_tests/test_tickets.py...
_ui_tests/test_tickets.py:12: def driver(request):
the previous way of writing fixtures was using funcargs:

def pytest_funcarg__driver(request):
    """A driver for a web browser."""
    driver = webdriver.Firefox()
    request.addfinalizer(driver.quit)
    return driver

this should work.

remember that MoinMoin/conftest.py needs to be copied to /conftest.py, the the
application context is set up.