Issue 10930043: Delete the xdg dependency in ibus-setup.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10930043: Delete the xdg dependency in ibus-setup. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by fujiwara

Modified:
10 years, 10 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Delete the python xdg dependency. BUG=RH#980749

Patch Set 1 #

Patch Set 2 : Updated with message #2. #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -9 lines)			Patch
M	debian/control	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ibus.spec.in	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ibus/common.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	setup/main.py	View		3 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fujiwara

Since that code has not been used in ibus-setup, I'd like to delete the xdg ...

10 years, 10 months ago (2013-07-04 03:07:52 UTC) #1

Peng

10 years, 10 months ago (2013-07-04 14:28:55 UTC) #2

On 2013/07/04 03:07:52, fujiwara wrote:
> Since that code has not been used in ibus-setup, I'd like to delete the xdg
> dependency.

Could you please check rpm.spec and debian packaging file and delete the
dependency as well? Thanks.
lgtm.

Expand All Messages | Collapse All Messages