Issue 1103: style applied to body in css or cascading from body in cajoled source not working

Fixes http://code.google.com/p/google-caja/issues/detail?id=1103

    body { font: 13px/1.231 Arial, helvetica, clean, sans-serif }
    p { font: 83%; }

    The cajoler removes the body declaration, making the p declaration
    relative to an inconsistent size across browsers.

    For full html pages passed to cajole_html, pages that include link
    elements for style, the resulting cajoled css omits the body rule
    rather than reassigning it to .gadget___ { font... }

    Perhaps there's an issue here with accepting 'inherit' as a value?
    Regardless, removing the rule altogether seems the wrong solution.

    This affects at least YUI reset.css, fonts.css, and grids.css.
    fonts.css (used to normalize element font sizes across browsers)
    specifically surfaces a use case like that noted above.


Submitted @3670

[ihab.awad, 2009-08-27 22:29:35]

LGTM

http://codereview.appspot.com/109083/diff/1006/1009
File src/com/google/caja/plugin/CssRuleRewriter.java (right):

http://codereview.appspot.com/109083/diff/1006/1009#newcode119
Line 119: elName.getFilePosition(), ".vdoc-body___"),
Should ".vdoc-body___" be entered into some collection of static final whatsits
somewhere?

http://codereview.appspot.com/109083/diff/1006/1008
File tests/com/google/caja/plugin/CssRuleRewriterTest.java (left):

http://codereview.appspot.com/109083/diff/1006/1008#oldcode57
Line 57: "[ '.', ' body.ie6 {\\n  color: blue\\n}' ]");
So -- just so I understand: Previously, we were passing through the "body" tag
but effectively neutering it by prefixing with the gadget ID class?

http://codereview.appspot.com/109083/diff/1006/1008
File tests/com/google/caja/plugin/CssRuleRewriterTest.java (right):

http://codereview.appspot.com/109083/diff/1006/1008#newcode60
Line 60: "[ '.vdoc-body___.', ' {\\n  font-size: 12pt\\n}' ]");
And fwiw, the new stuff looks reasonable, so no need to hold up the checkin.

[MikeSamuel, 2009-08-27 23:41:20]

http://codereview.appspot.com/109083/diff/1006/1009
File src/com/google/caja/plugin/CssRuleRewriter.java (right):

http://codereview.appspot.com/109083/diff/1006/1009#newcode119
Line 119: elName.getFilePosition(), ".vdoc-body___"),
On 2009/08/27 22:29:35, ihab.awad wrote:
> Should ".vdoc-body___" be entered into some collection of static final
whatsits
> somewhere?

It's not really appropriate for ReservedNames.java since it isn't in the JS
identifier namespace.

It is documented at
http://code.google.com/p/google-caja/source/browse/trunk/src/com/google/caja/...