Issue 109081: Add some methods to Expression that make it easier to generate JS code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 109081: Add some methods to Expression that make it easier to generate JS code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 7 months ago by MikeSamuel

Modified:
16 years, 7 months ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Adds two methods, simplifyForSideEffect, and conditionResult to the base Expression interface. Please see that class for detail first, and ExpressionTest for uses. Submitted @3659

Patch Set 1 #

Created: 16 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+232 lines, -7 lines)			Patch
M	src/com/google/caja/parser/js/AbstractExpression.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/ArrayConstructor.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Expression.java	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/FunctionConstructor.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Literal.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/NullLiteral.java	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	src/com/google/caja/parser/js/ObjectConstructor.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/com/google/caja/parser/js/Operation.java	View	1 chunk	+68 lines, -0 lines	0 comments	Download
A	tests/com/google/caja/parser/js/ExpressionTest.java	View	1 chunk	+118 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/parser/js/JsFunFuzz.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
MM	tests/com/google/caja/parser/js/parsertest4.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
MM	tests/com/google/caja/parser/js/rendergolden4.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages